6453901: (cal) clean up sun.util.calendar classes

[justin-curtis-lu]

This PR includes cleanup changes to the sun.util.calendar package only.

The changes include removing unused methods, imports, adjusting incorrect links, and using newer syntax patterns. Since there are no plans to promote any of these classes to java.calendar, these unused methods can be removed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-6453901: (cal) clean up sun.util.calendar classes

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12817/head:pull/12817
$ git checkout pull/12817

Update a local copy of the PR:
$ git checkout pull/12817
$ git pull https://git.openjdk.org/jdk pull/12817/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12817

View PR using the GUI difftool:
$ git pr show -t 12817

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12817.diff

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0753aea3)

[naotoj]

Nice cleanup for removing dead code.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6453901: (cal) clean up sun.util.calendar classes

Reviewed-by: naoto, lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

• acf8996: 8303275: Use {@return and @linkplain in Locale and related classes
• ac3ab5b: 8217496: Matcher.group() can return null after usePattern
• 45a616a: 8303480: Miscellaneous fixes to mostly invisible doc comments
• 43288bb: 8301477: Replace NULL with nullptr in os/aix
• 008c5eb: 8303621: BitMap::iterate should support lambdas and other function objects
• 52d3008: 8303497: [s390x] ProblemList TestUnreachableInnerLoop.java
• 3f2d929: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling
• 7fbfc88: 8303534: Merge CompactibleSpace into ContiguousSpace
• 97c25df: 8204550: NMT: RegionIterator does not need to keep _current_size
• 94eda53: 8201516: DebugNonSafepoints generates incorrect information
• ... and 48 more: https://git.openjdk.org/jdk/compare/f3abc4063de658418283aee1f552c4b4976e5211...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[justin-curtis-lu]

/integrate

[openjdk]

@justin-curtis-lu An unexpected error occurred during integration. No push attempt will be made. The error has been logged and will be investigated. It is possible that this error is caused by a transient issue; feel free to retry the operation.

[naotoj]

/sponsor

[openjdk]

@naotoj The change author (@justin-curtis-lu) must issue an integrate command before the integration can be sponsored.

[justin-curtis-lu]

/integrate

[openjdk]

@justin-curtis-lu
Your change (at version 0753aea) is now ready to be sponsored by a Committer.

[naotoj]

/sponsor

[openjdk]

Going to push as commit f1f4e1d.
Since your change was applied there have been 58 commits pushed to the master branch:

• acf8996: 8303275: Use {@return and @linkplain in Locale and related classes
• ac3ab5b: 8217496: Matcher.group() can return null after usePattern
• 45a616a: 8303480: Miscellaneous fixes to mostly invisible doc comments
• 43288bb: 8301477: Replace NULL with nullptr in os/aix
• 008c5eb: 8303621: BitMap::iterate should support lambdas and other function objects
• 52d3008: 8303497: [s390x] ProblemList TestUnreachableInnerLoop.java
• 3f2d929: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling
• 7fbfc88: 8303534: Merge CompactibleSpace into ContiguousSpace
• 97c25df: 8204550: NMT: RegionIterator does not need to keep _current_size
• 94eda53: 8201516: DebugNonSafepoints generates incorrect information
• ... and 48 more: https://git.openjdk.org/jdk/compare/f3abc4063de658418283aee1f552c4b4976e5211...master

Your commit was automatically rebased without conflicts.

[openjdk]

@naotoj @justin-curtis-lu Pushed as commit f1f4e1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.