8294137: Review running times of java.math tests

[bplb]

Break up BigIntegerTest and SymmetricRangeTests into subsets which are run quasi-randomly as a function of second within the minute at the time the test is running. LargeValueExceptions does not appear amenable to this treatment.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8294137: Review running times of java.math tests

Reviewers

• Joe Darcy (@jddarcy - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12819/head:pull/12819
$ git checkout pull/12819

Update a local copy of the PR:
$ git checkout pull/12819
$ git pull https://git.openjdk.org/jdk.git pull/12819/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12819

View PR using the GUI difftool:
$ git pr show -t 12819

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12819.diff

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bplb]

The full running time of BigIntegerTest was measured using time to be 24.983s. The running times of its subsets were measured to be

subset	run time (s)
1	14.379
2	10.946
3	18.033

The full running time of SymmetricRangeTests was measured using time to be 42.191s. The running times of its subsets were measured to be

subset	run time (s)
1	16.997
2	16.838
3	16.047
4	19.276

Note that in both cases the overhead of each subset is probably about the same as that of the full test.

[mlbridge]

Webrevs

• 02: Full - Incremental (8c666401)
• 01: Full - Incremental (ca998b8e)
• 00: Full (3128f03c)

[rgiulietti]

LGTM

[jddarcy]

Hmmm.

There are fairly standard idioms to get a random number generator from the test library and use it in the test.

I'd prefer to see that approach taken here, with an update to use the jtreg "@randomness" tag in the appropriate place.

[bplb]

There are fairly standard idioms to get a random number generator from the test library and use it in the test.

I'd prefer to see that approach taken here, with an update to use the jtreg "@randomness" tag in the appropriate place.

So changed in ca998b8. The @randomness tag was already there for other reasons.

[jddarcy]

Hmm. What do you think about an idiom where it would be easy (through a small source change at least) to run all the subtests?

So the default selection could look for, say, a bit in position N being set rather than the selector being N.

[bplb]

[...] an idiom where it would be easy (through a small source change at least) to run all the subtests?

Addressed in 8c66640.

[jddarcy]

Looks okay -- if in the future there is a more general mechanism to support this kind of sub-setting the test should be transitioned to use that.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294137: Review running times of java.math tests

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 324 new commits pushed to the master branch:

• 6fa25cc: 8184444: The compiler error "variable not initialized in the default constructor" is not apt in case of static final variables
• 4b8f7db: 8027682: javac wrongly accepts semicolons in package and import decls
• c00d088: 8043179: Lambda expression can mutate final field
• 147f347: 8219083: java/net/MulticastSocket/SetGetNetworkInterfaceTest.java failed in same binary run on windows x64
• bf917ba: 8304687: Move add_to_hierarchy
• 63d4afb: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers
• e2cfcfb: 6817009: Action.SELECTED_KEY not toggled when using key binding
• af4d560: 8303951: Add asserts before record_method_not_compilable where possible
• c433862: 6245410: javax.swing.text.html.CSS.Attribute: BACKGROUND_POSITION is not w3c spec compliant
• 91f407d: 8029301: Confusing error message for array creation method reference
• ... and 314 more: https://git.openjdk.org/jdk/compare/b527edd3388ad6a0d44a291983b08b2b5c023f8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit 51035a7.
Since your change was applied there have been 325 commits pushed to the master branch:

• 46cca1a: 4842457: (bf spec) Clarify meaning of "(optional operation)"
• 6fa25cc: 8184444: The compiler error "variable not initialized in the default constructor" is not apt in case of static final variables
• 4b8f7db: 8027682: javac wrongly accepts semicolons in package and import decls
• c00d088: 8043179: Lambda expression can mutate final field
• 147f347: 8219083: java/net/MulticastSocket/SetGetNetworkInterfaceTest.java failed in same binary run on windows x64
• bf917ba: 8304687: Move add_to_hierarchy
• 63d4afb: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers
• e2cfcfb: 6817009: Action.SELECTED_KEY not toggled when using key binding
• af4d560: 8303951: Add asserts before record_method_not_compilable where possible
• c433862: 6245410: javax.swing.text.html.CSS.Attribute: BACKGROUND_POSITION is not w3c spec compliant
• ... and 315 more: https://git.openjdk.org/jdk/compare/b527edd3388ad6a0d44a291983b08b2b5c023f8f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 51035a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.