8303499: [s390x] ProblemList StressStackOverflow

[offamitkumar]

This PR adds StressStackOverflow.java test to ProblemList. The feature Scope Value is not yet implemented on s390x-arch which is Incubating state. Whenever fix will be given to JDK-8303498 then we will remove it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303499: [s390x] ProblemList StressStackOverflow

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12834/head:pull/12834
$ git checkout pull/12834

Update a local copy of the PR:
$ git checkout pull/12834
$ git pull https://git.openjdk.org/jdk pull/12834/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12834

View PR using the GUI difftool:
$ git pr show -t 12834

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12834.diff

[bridgekeeper]

👋 Welcome back offamitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@offamitkumar To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[AlanBateman]

If scoped values aren't implemented on s390x then I would expect several other tests to fail, e.g. ScopeValueAPI.java, ManyBindings.java, StructuredTaskScope/WithScopedValue.java, ThreadFlock/WithScopedValue.java. So I suspect something else is going on here. Maybe it's stack overflow handling?

[offamitkumar]

Alan I'm attaching JTR file could you confirm the same probably provide more insights, as test you mentioned ScopeValueAPI.java and ManyBindings.java are passing.
StressStackOverflow.log

[AlanBateman]

Alan I'm attaching JTR file could you confirm the same probably provide more insights, as test you mentioned ScopeValueAPI.java and ManyBindings.java are passing.
StressStackOverflow.log

@theRealAph may wish to comment on this issue.

If ScopeValueAPI.java and ManyBindings.java are passing then it suggests that ScopeValue API is at least functional. The JEP 429 implementation did have a small change to C2 (look at git show 221e1a426070088b819ddc37b7ca77d9d8626eb4 src/hotspot/cpu) and maybe the equivalent changes for s390x have not done been done yet.

Excluding the test via the ProblemList until the s390x work is done seem reasonable.

[AlanBateman]

/label add core-libs

[openjdk]

@AlanBateman
The core-libs label was successfully added.

[openjdk]

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303499: [s390x] ProblemList StressStackOverflow

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

• c961a91: 8143900: OptimizeStringConcat has an opaque dependency on Integer.sizeTable field
• 35003b5: 8302830: AArch64: Fix the mismatch between cas.m4 and aarch64.ad
• f3abc40: 8302783: Improve CRC32C intrinsic with crypto pmull on AArch64
• 45d8a17: 8303405: fix @returnss typo in ReflectionFactory
• e7113dc: 8302495: update for deprecated sprintf for java.desktop
• 843d632: 8303442: Clean up w2k_lsa_auth linker parameters
• d4dcba0: 8303267: Prefer ArrayList to LinkedList in ConcurrentLocksPrinter
• 2c7d2c0: 8303411: JFR problem list entry for JDK-8247776 should be removed
• 0b63557: 8303039: Utilize coverageLevels.txt
• 32247c3: 8303476: Add the runtime version in the release file of a JDK image
• ... and 82 more: https://git.openjdk.org/jdk/compare/1bab93b2d0ca62189fee1783d8796d056353c72e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[offamitkumar]

These are trivial changes. So I guess 1 Reviewer should be enough.
/integrate

please sponsor accordingly.

[openjdk]

@offamitkumar
Your change (at version 49eaeca) is now ready to be sponsored by a Committer.

[mlbridge]

Webrevs

• 00: Full (49eaeca1)

[AlanBateman]

/sponsor

[openjdk]

Going to push as commit 8bf084c.
Since your change was applied there have been 97 commits pushed to the master branch:

• ff364c1: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning
• df9aad0: 8297955: LDAP CertStore should use LdapName and not String for DNs
• d23a8bf: 8297753: AArch64: Add optimized rules for vector compare with zero on NEON
• 339ca88: 8303539: javadoc typos in Attr
• e1745bc: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles
• c961a91: 8143900: OptimizeStringConcat has an opaque dependency on Integer.sizeTable field
• 35003b5: 8302830: AArch64: Fix the mismatch between cas.m4 and aarch64.ad
• f3abc40: 8302783: Improve CRC32C intrinsic with crypto pmull on AArch64
• 45d8a17: 8303405: fix @returnss typo in ReflectionFactory
• e7113dc: 8302495: update for deprecated sprintf for java.desktop
• ... and 87 more: https://git.openjdk.org/jdk/compare/1bab93b2d0ca62189fee1783d8796d056353c72e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman @offamitkumar Pushed as commit 8bf084c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

Wouldn't this also be an issue on AIX?

[offamitkumar]

Yes @dholmes-ora it is, and I informed Tyler Steele about it.