8297605: improve DelayQueue removal method javadoc

[Martin-Buchholz]

Inviting @DougLea and @viktorklang-ora to review.

As usual, I couldn't resist more fiddling.

• Added missing tests for take, remove(), remove(Object).
• Improved DelayQueueTest's testing infrastructure
• added more test assertions
• linkified new javadoc definitions

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8304686 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8297605: improve DelayQueue removal method javadoc
• JDK-8304686: improve DelayQueue removal method javadoc (CSR)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to fb14b2f3

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12838/head:pull/12838
$ git checkout pull/12838

Update a local copy of the PR:
$ git checkout pull/12838
$ git pull https://git.openjdk.org/jdk.git pull/12838/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12838

View PR using the GUI difftool:
$ git pr show -t 12838

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12838.diff

[bridgekeeper]

👋 Welcome back martin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Martin-Buchholz The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (4d02235a)
• 00: Full (fb14b2f3)

[DougLea]

Thanks. This is overkill, but the wording changes and new tests look OK.

[viktorklang-ora]

@Martin-Buchholz I think the updated documentation is clearer. We need some extra reviewers like @AlanBateman or @pron to sign off :)

[AlanBateman]

/csr

[AlanBateman]

Wordy but clear, I think it's okay.

[openjdk]

@Martin-Buchholz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297605: improve DelayQueue removal method javadoc

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 426 new commits pushed to the master branch:

• cccb019: 8304928: Optimize ClassDesc.resolveConstantDesc
• bdbf8fc: 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value
• 4a5d7ca: 8305227: [s390x] build broken after JDK-8231349
• dae1ab3: 8304844: JFR: Missing disk parameter in ActiveRecording event
• e012685: 8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized
• fe42312: 8304820: Statically allocate ObjectSynchronizer mutexes
• 2f36eb0: 8305323: Update java/net/httpclient/ContentLengthHeaderTest.java to use new HttpTestServer factory methods
• 049b953: 8305223: IGV: mark osr compiled graphs with [OSR] in the name
• 345669c: 8302738: IGV: refine 'Simplify graph' filter
• dea9db2: 8305055: IR check fails on some aarch64 platforms
• ... and 416 more: https://git.openjdk.org/jdk/compare/1e3c9fd67efd8428f702c7a3e26ac2b60e0fe618...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@Martin-Buchholz please create a CSR request for issue JDK-8297605 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[Martin-Buchholz]

/integrate

[openjdk]

Going to push as commit a565be4.
Since your change was applied there have been 426 commits pushed to the master branch:

• cccb019: 8304928: Optimize ClassDesc.resolveConstantDesc
• bdbf8fc: 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value
• 4a5d7ca: 8305227: [s390x] build broken after JDK-8231349
• dae1ab3: 8304844: JFR: Missing disk parameter in ActiveRecording event
• e012685: 8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized
• fe42312: 8304820: Statically allocate ObjectSynchronizer mutexes
• 2f36eb0: 8305323: Update java/net/httpclient/ContentLengthHeaderTest.java to use new HttpTestServer factory methods
• 049b953: 8305223: IGV: mark osr compiled graphs with [OSR] in the name
• 345669c: 8302738: IGV: refine 'Simplify graph' filter
• dea9db2: 8305055: IR check fails on some aarch64 platforms
• ... and 416 more: https://git.openjdk.org/jdk/compare/1e3c9fd67efd8428f702c7a3e26ac2b60e0fe618...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Martin-Buchholz Pushed as commit a565be4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[viktorklang-ora]

Nice work @Martin-Buchholz! 👍