Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8210253: Clipped UI rendering with X11 pipeline and HiDPI #1284

Closed
wants to merge 2 commits into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Nov 18, 2020

The fix for https://bugs.openjdk.java.net/browse/JDK-8137571 where HiDPI support on Linux was implemented missed the change in the X11 pipeline, only XRender pipeline was updated. The same logic should be implemented in X11SurfaceData:

  • The size of the native surface should be scaled based on scale factor, except the TEXTURE type, because it is used for managed(cached) images.

See the old change:
d48c3fc#diff-8e84507066ac1c725caee14aa6a3323b0fb06f2082a33e0c5dbe2c662bdc53ccR545

I hit this bug on my local system, and confirm that this change cures it. mach5 is green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8210253: Clipped UI rendering with X11 pipeline and HiDPI

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1284/head:pull/1284
$ git checkout pull/1284

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 18, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 18, 2020

@mrserb The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d label Nov 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 18, 2020

Webrevs

@mrserb
Copy link
Member Author

@mrserb mrserb commented Nov 30, 2020

Any volunteers for a review?

@victordyakov
Copy link

@victordyakov victordyakov commented Nov 30, 2020

@prsadhuk @Kizune please review

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

The changes are similar to Xrender, looks reasonable.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8210253: Clipped UI rendering with X11 pipeline and HiDPI

Reviewed-by: aivanov, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 236 new commits pushed to the master branch:

  • 56b15fb: 8159746: (proxy) Support for default methods
  • 1433baf: 8253751: Dependencies of automatic modules are not propagated through module layers
  • e3d0f27: 8257231: assert(!is_mcall || (call_returns[block->_pre_order] <= (uint) current_offset))
  • eaf4db6: 8257502: Builds fail with new warnings after JDK-8256254
  • 2966d0d: 8257223: C2: Optimize RegMask::is_bound
  • 3a11009: 8256830: misc tests failed with "assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking"
  • c859fb0: 8249836: java/io/IOException/LastErrorString.java should have bug-id as 1st word in @ignore
  • e0de28c: 8257424: RecordingStream does not specify the recording name
  • 60f2ba9: 8257487: Include configuration name in summary
  • 021dced: 8257415: ZGC: Fix barrier_data types
  • ... and 226 more: https://git.openjdk.java.net/jdk/compare/c08921487bdd400c341f49a781841920f0583716...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 30, 2020
Copy link
Member

@azuev-java azuev-java left a comment

Looks ok.

@mrserb
Copy link
Member Author

@mrserb mrserb commented Dec 2, 2020

/integrate

@openjdk openjdk bot closed this Dec 2, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 2, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 2, 2020

@mrserb Since your change was applied there have been 242 commits pushed to the master branch:

  • ce496cb: 8257190: simplify PhaseIdealLoop constructors
  • 927504e: 8256474: Migrate Mutex _owner accesses to use Atomic operations
  • 00e79db: 8257511: JDK-8254082 brings regression to AbstractStringBuilder.insert(int dstOffset, CharSequence s, int start, int end)
  • 015e6e5: 8257460: Further CompilerOracle cleanup
  • 29d90b9: 8255968: Confusing error message for inaccessible constructor
  • c5046ca: 8246739: InputStream.skipNBytes could be implemented more efficiently
  • 56b15fb: 8159746: (proxy) Support for default methods
  • 1433baf: 8253751: Dependencies of automatic modules are not propagated through module layers
  • e3d0f27: 8257231: assert(!is_mcall || (call_returns[block->_pre_order] <= (uint) current_offset))
  • eaf4db6: 8257502: Builds fail with new warnings after JDK-8256254
  • ... and 232 more: https://git.openjdk.java.net/jdk/compare/c08921487bdd400c341f49a781841920f0583716...master

Your commit was automatically rebased without conflicts.

Pushed as commit 03f3b8e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8210253 branch Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants