8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls

[dholmes-ora]

We can replace gethostbyname, which is deprecated on Windows and Linux, with getaddrinfo. This API is available on all supported platforms and so can be placed in shared code. @djelinski pointed out that getaddrinfo can resolve both IP addresses and host names so the two step approach used in networkStream::connect is not necessary and we can do away with os::get_host_by_name() completely.

The build is updated to enable winsock deprecation warnings, and now we need to use ws2_32.lib we can drop wsock32.lib (as it is basically a subset - again thanks @djelinski ).

Testing
- all Oracle builds in tiers 1-5
- All GHA builds

The actual code change has to be manually tested because the code is only used by Ideal Graph Printing to connect to the Ideal Graph Visualizer. I've manually tested on Windows and Linux and @tobiasholenstein tested macOS.

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls

Reviewers

• Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to 81f15e05
• Daniel Jeliński (@djelinski - Committer)

Contributors

• Daniel Jeliński <djelinski@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12842/head:pull/12842
$ git checkout pull/12842

Update a local copy of the PR:
$ git checkout pull/12842
$ git pull https://git.openjdk.org/jdk pull/12842/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12842

View PR using the GUI difftool:
$ git pr show -t 12842

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12842.diff

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora The following labels will be automatically applied to this pull request:

• build
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[dholmes-ora]

/contributor add @djelinski

[openjdk]

@dholmes-ora
Contributor Daniel Jeliński <djelinski@openjdk.org> successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (8b6f6317)
• 00: Full (81f15e05)

[dholmes-ora]

I forgot to mention I have no way to test on AIX so if someone were able to do that, that would be good. Thanks. I know it builds okay.

[kimbarrett]

Looks good.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls

Co-authored-by: Daniel Jeliński <djelinski@openjdk.org>
Reviewed-by: kbarrett, djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• 339ca88: 8303539: javadoc typos in Attr
• e1745bc: 8303473: Add implied {@code} in java.lang.invoke.MethodHandles
• c961a91: 8143900: OptimizeStringConcat has an opaque dependency on Integer.sizeTable field
• 35003b5: 8302830: AArch64: Fix the mismatch between cas.m4 and aarch64.ad
• f3abc40: 8302783: Improve CRC32C intrinsic with crypto pmull on AArch64
• 45d8a17: 8303405: fix @returnss typo in ReflectionFactory
• e7113dc: 8302495: update for deprecated sprintf for java.desktop
• 843d632: 8303442: Clean up w2k_lsa_auth linker parameters
• d4dcba0: 8303267: Prefer ArrayList to LinkedList in ConcurrentLocksPrinter
• 2c7d2c0: 8303411: JFR problem list entry for JDK-8247776 should be removed
• ... and 29 more: https://git.openjdk.org/jdk/compare/881517586d7b6d26c5589c3459902eb964ce9030...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Thanks for the reviews @kimbarrett and @djelinski ! I'll leave this till early next week to integrate.

[dholmes-ora]

/integrate

[openjdk]

Going to push as commit d729824.
Since your change was applied there have been 99 commits pushed to the master branch:

• 5f1108f: 8303151: DCmd framework cleanups
• 32f4d8b: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null
• 9f9d678: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message
• b5b5cba: 8302801: Remove fdlibm C sources
• 4d4eade: 8302452: [JVMCI] Export _poly1305_processBlocks, JfrThreadLocal fields to JVMCI compiler.
• f1f4e1d: 6453901: (cal) clean up sun.util.calendar classes
• acf8996: 8303275: Use {@return and @linkplain in Locale and related classes
• ac3ab5b: 8217496: Matcher.group() can return null after usePattern
• 45a616a: 8303480: Miscellaneous fixes to mostly invisible doc comments
• 43288bb: 8301477: Replace NULL with nullptr in os/aix
• ... and 89 more: https://git.openjdk.org/jdk/compare/881517586d7b6d26c5589c3459902eb964ce9030...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit d729824.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.