JDK-8303540: Eliminate unnecessary reference to javac internal class

[jonathan-gibbons]

Please review a trivial cleanup, to remove the unnecessary use of a javac internal type, when the public supertype is sufficient.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303540: Eliminate unnecessary reference to javac internal class

Reviewers

• Hannes Wallnöfer (@hns - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12844/head:pull/12844
$ git checkout pull/12844

Update a local copy of the PR:
$ git checkout pull/12844
$ git pull https://git.openjdk.org/jdk pull/12844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12844

View PR using the GUI difftool:
$ git pr show -t 12844

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12844.diff

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jonathan-gibbons The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[hns]

Looks good.

[hns]

Seems like github hasn't made the connection to the JBS issue.

[openjdk]

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303540: Eliminate unnecessary reference to javac internal class

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• ccfe167: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test
• cfb0a25: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id
• a97271e: 8301793: AlgorithmId should not encode a missing parameters field as NULL unless hardcoded
• cac81dd: 8303577: [JVMCI] OOME causes crash while translating exceptions
• 877ab65: 8303264: Refactor nsk/stress/strace to extract shared and remove redundant code
• ae8730f: 8303486: [REDO] Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.
• 5977f26: 8303604: Passing by-value structs whose size is not power of 2 doesn't work on all platforms (mainline)
• dccfe8a: 8303582: Reduce duplication in jdk/java/foreign tests
• 8e20145: 8300654: Remove JVMFlag::flag_error_str as it is unused
• bdffe46: 8301222: Generalize check_release_entry in OopStorage
• ... and 36 more: https://git.openjdk.org/jdk/compare/f3abc4063de658418283aee1f552c4b4976e5211...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jonathan-gibbons]

/integrate

[openjdk]

Going to push as commit f64ed09.
Since your change was applied there have been 46 commits pushed to the master branch:

• ccfe167: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test
• cfb0a25: 8303440: The "ZonedDateTime.parse" may not accept the "UTC+XX" zone id
• a97271e: 8301793: AlgorithmId should not encode a missing parameters field as NULL unless hardcoded
• cac81dd: 8303577: [JVMCI] OOME causes crash while translating exceptions
• 877ab65: 8303264: Refactor nsk/stress/strace to extract shared and remove redundant code
• ae8730f: 8303486: [REDO] Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed.
• 5977f26: 8303604: Passing by-value structs whose size is not power of 2 doesn't work on all platforms (mainline)
• dccfe8a: 8303582: Reduce duplication in jdk/java/foreign tests
• 8e20145: 8300654: Remove JVMFlag::flag_error_str as it is unused
• bdffe46: 8301222: Generalize check_release_entry in OopStorage
• ... and 36 more: https://git.openjdk.org/jdk/compare/f3abc4063de658418283aee1f552c4b4976e5211...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons Pushed as commit f64ed09.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Webrevs

• 00: Full (414ba4a3)