Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300821: UB: Applying non-zero offset to non-null pointer 0xfffffffffffffffe produced null pointer #12854

Closed

Conversation

tobiasholenstein
Copy link
Contributor

@tobiasholenstein tobiasholenstein commented Mar 3, 2023

"UndefinedBehaviorSanitizer" (https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html) in Xcode running on java --version discovered an Undefined Behavior. The reason is in the next() method

while (iter.next()) {

In RelocIterator::next() we get a nullpointer after _current++


But this is actually expected: In the constructor of the iterator RelocIterator::RelocIterator we have

_current = cs->locs_start()-1;
_end     = cs->locs_end();

and in our case locs_start() and locs_end() are null - so _current is null-1. After _current++ both _end and _current are null. Just after _current++ we then check if _current == _end and return false (there is no next reloc info)

Solution

We want to be able to turn on "UndefinedBehaviorSanitizer" and don't have false positives. So we add a check
cs->has_locs() and only create the iterator if we have reloc info.

Also added a sanity check in RelocIterator::RelocIterator that checks that either both _current and _end are null or both are not null.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300821: UB: Applying non-zero offset to non-null pointer 0xfffffffffffffffe produced null pointer

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12854/head:pull/12854
$ git checkout pull/12854

Update a local copy of the PR:
$ git checkout pull/12854
$ git pull https://git.openjdk.org/jdk pull/12854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12854

View PR using the GUI difftool:
$ git pr show -t 12854

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12854.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2023

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 3, 2023

@tobiasholenstein The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 3, 2023
@tobiasholenstein tobiasholenstein marked this pull request as ready for review March 7, 2023 13:36
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 7, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2023

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Mar 8, 2023

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300821: UB: Applying non-zero offset to non-null pointer 0xfffffffffffffffe produced null pointer

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 133 new commits pushed to the master branch:

  • afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
  • 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
  • 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
  • 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
  • 5fa9bd4: 8302189: Mark assertion failures noreturn
  • 9b10c69: 8303622: JFR: Missing message with Objects.requireNonNull
  • d729824: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
  • 5f1108f: 8303151: DCmd framework cleanups
  • 32f4d8b: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null
  • 9f9d678: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message
  • ... and 123 more: https://git.openjdk.org/jdk/compare/a2c5a4ac9ee10281470f291f5a8f8393acea02cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 8, 2023
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tobiasholenstein
Copy link
Contributor Author

thanks @vnkozlov and @TobiHartmann for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2023

Going to push as commit 01312a0.
Since your change was applied there have been 176 commits pushed to the master branch:

  • 6d30bbe: 8303001: Add test for re-entrant upcalls
  • de9f3b6: 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL
  • b9951dd: 8303820: Simplify type metadata
  • 75d6306: 8303349: Simplify link format for generic types in index pages
  • b1d89f3: 8294971: jdk.jlink jdk.tools.jimage.JImageTask is using ASM to verify classes
  • 0f26d09: 8303822: gtestMain should give more helpful output
  • e26cc52: 8303624: The java.lang.Thread.FieldHolder can be null for JNI attaching threads
  • d06308c: 8302360: Atomic*.compareAndExchange Javadoc unclear
  • 8b740b4: 8302779: HelidonAppTest.java fails with "assert(_cb == CodeCache::find_blob(pc())) failed: Must be the same" or SIGSEGV
  • 562c8fc: 8303691: Fedora based devkit build should load more packages from archive location
  • ... and 166 more: https://git.openjdk.org/jdk/compare/a2c5a4ac9ee10281470f291f5a8f8393acea02cc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2023
@openjdk openjdk bot closed this Mar 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2023
@openjdk
Copy link

openjdk bot commented Mar 10, 2023

@tobiasholenstein Pushed as commit 01312a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants