JDK-8303605: Memory leaks in Metaspace gtests

[jcking]

Fix memory leaks identified while running Metaspace gtests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8303605: Memory leaks in Metaspace gtests

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12865/head:pull/12865
$ git checkout pull/12865

Update a local copy of the PR:
$ git checkout pull/12865
$ git pull https://git.openjdk.org/jdk pull/12865/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12865

View PR using the GUI difftool:
$ git pr show -t 12865

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12865.diff

[bridgekeeper]

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jcking The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (5b368b60)
• 02: Full - Incremental (57df305e)
• 01: Full - Incremental (b4b96a2e)
• 00: Full (744abfa0)

[tstuefe]

Mostly good, small nits remain.

[tstuefe]

Good!

[openjdk]

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303605: Memory leaks in Metaspace gtests

Reviewed-by: stuefe, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
• 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
• 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
• 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
• 5fa9bd4: 8302189: Mark assertion failures noreturn
• 9b10c69: 8303622: JFR: Missing message with Objects.requireNonNull
• d729824: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
• 5f1108f: 8303151: DCmd framework cleanups
• 32f4d8b: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null
• 9f9d678: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message
• ... and 39 more: https://git.openjdk.org/jdk/compare/ae290541d17be77bbedf56a4592102ead4e4691e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jcking]

/reviewers 2

[openjdk]

@jcking
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[dholmes-ora]

Seems okay. Thanks.

[jcking]

Failed GHA is unrelated.

[jcking]

/integrate

[openjdk]

Going to push as commit ddcb369.
Since your change was applied there have been 52 commits pushed to the master branch:

• 56512cf: 8303682: Simplify HttpClient DebugLogger
• 8eaf84f: 8303575: adjust Xen handling on Linux aarch64
• d988252: 8303443: IGV: Syntax highlighting and resizing for filter editor
• afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
• 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
• 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
• 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
• 5fa9bd4: 8302189: Mark assertion failures noreturn
• 9b10c69: 8303622: JFR: Missing message with Objects.requireNonNull
• d729824: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
• ... and 42 more: https://git.openjdk.org/jdk/compare/ae290541d17be77bbedf56a4592102ead4e4691e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jcking Pushed as commit ddcb369.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.