8303617: update for deprecated sprintf for jdk.jdwp.agent

[XueleiFan]

Hi,

May I have this update reviewed?

The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of security concerns. The issue was addressed in JDK-8296812 for building failure, and JDK-8299378/JDK-8299635/JDK-8301132 for testing issues . This is a break-down update for sprintf uses in jdk.jdwp.agent module.

Thanks,
Xuelei

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8303617: update for deprecated sprintf for jdk.jdwp.agent

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12870/head:pull/12870
$ git checkout pull/12870

Update a local copy of the PR:
$ git checkout pull/12870
$ git pull https://git.openjdk.org/jdk pull/12870/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12870

View PR using the GUI difftool:
$ git pr show -t 12870

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12870.diff

[bridgekeeper]

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@XueleiFan The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[XueleiFan]

/reviewers 2

[openjdk]

@XueleiFan
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[mlbridge]

Webrevs

• 02: Full - Incremental (905e2e31)
• 01: Full - Incremental (d5150653)
• 00: Full (10c9be47)

[plummercj]

Copyright needs updating.

[plummercj]

windows/native/libjdwp/linker_md.c also needs its copyright updated.

[XueleiFan]

windows/native/libjdwp/linker_md.c also needs its copyright updated.

Ooops, I missed this file. Updated. Thanks!

[sspitsyn]

Looks good.
Thanks,
Serguei

[openjdk]

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303617: update for deprecated sprintf for jdk.jdwp.agent

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

• 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
• 5fa9bd4: 8302189: Mark assertion failures noreturn
• 9b10c69: 8303622: JFR: Missing message with Objects.requireNonNull
• d729824: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
• 5f1108f: 8303151: DCmd framework cleanups
• 32f4d8b: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null
• 9f9d678: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message
• b5b5cba: 8302801: Remove fdlibm C sources
• 4d4eade: 8302452: [JVMCI] Export _poly1305_processBlocks, JfrThreadLocal fields to JVMCI compiler.
• f1f4e1d: 6453901: (cal) clean up sun.util.calendar classes
• ... and 34 more: https://git.openjdk.org/jdk/compare/5b2e2e4695768a6bd8090fb9a6c342fcddcbb3fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[XueleiFan]

/integrate

[openjdk]

Going to push as commit d287a5e.
Since your change was applied there have been 51 commits pushed to the master branch:

• ddcb369: 8303605: Memory leaks in Metaspace gtests
• 56512cf: 8303682: Simplify HttpClient DebugLogger
• 8eaf84f: 8303575: adjust Xen handling on Linux aarch64
• d988252: 8303443: IGV: Syntax highlighting and resizing for filter editor
• afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
• 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
• 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
• 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
• 5fa9bd4: 8302189: Mark assertion failures noreturn
• 9b10c69: 8303622: JFR: Missing message with Objects.requireNonNull
• ... and 41 more: https://git.openjdk.org/jdk/compare/5b2e2e4695768a6bd8090fb9a6c342fcddcbb3fd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@XueleiFan Pushed as commit d287a5e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.