New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8303630: Move nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java back to general problem list #12875
Conversation
… general problem list
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label serviceability |
@plummercj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine and trivial. Thanks for fixing.
I would suggest making this JBS issue a subtask of JDK-8277573
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks David! /integrate |
Going to push as commit 3eff1a0. |
@plummercj Pushed as commit 3eff1a0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java was just moved to the -Xcomp problem list, but it looks like it can happen without -Xcomp, although it looks like JFR is required in this case. In any case, it needs to move back to the general problem list.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12875/head:pull/12875
$ git checkout pull/12875
Update a local copy of the PR:
$ git checkout pull/12875
$ git pull https://git.openjdk.org/jdk pull/12875/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12875
View PR using the GUI difftool:
$ git pr show -t 12875
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12875.diff