Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303630: Move nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java back to general problem list #12875

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Mar 6, 2023

nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java was just moved to the -Xcomp problem list, but it looks like it can happen without -Xcomp, although it looks like JFR is required in this case. In any case, it needs to move back to the general problem list.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303630: Move nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java back to general problem list

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12875/head:pull/12875
$ git checkout pull/12875

Update a local copy of the PR:
$ git checkout pull/12875
$ git pull https://git.openjdk.org/jdk pull/12875/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12875

View PR using the GUI difftool:
$ git pr show -t 12875

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12875.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2023

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8303630 8303630: Move nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java back to general problem list Mar 6, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2023
@openjdk
Copy link

openjdk bot commented Mar 6, 2023

@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@plummercj
Copy link
Contributor Author

/label serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Mar 6, 2023
@openjdk
Copy link

openjdk bot commented Mar 6, 2023

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Mar 6, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and trivial. Thanks for fixing.

I would suggest making this JBS issue a subtask of JDK-8277573

@openjdk
Copy link

openjdk bot commented Mar 6, 2023

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303630: Move nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java back to general problem list

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2023
@plummercj
Copy link
Contributor Author

Thanks David!

/integrate

@openjdk
Copy link

openjdk bot commented Mar 6, 2023

Going to push as commit 3eff1a0.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 6, 2023
@openjdk openjdk bot closed this Mar 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2023
@openjdk
Copy link

openjdk bot commented Mar 6, 2023

@plummercj Pushed as commit 3eff1a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants