Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8303678: [JVMCI] Add possibility to convert object JavaConstant to jobject. #12882

Closed
wants to merge 1 commit into from

Conversation

tzezula
Copy link

@tzezula tzezula commented Mar 6, 2023

This pull request adds a jdk.vm.ci.hotspot.HotSpotJVMCIRuntime#getJObjectValue(HotSpotObjectConstant peerObject) method, which gets a reference to an object in the peer runtime wrapped by the jdk.vm.ci.hotspot.IndirectHotSpotObjectConstantImpl. The reference is returned as a HotSpot heap JNI jobject.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303678: [JVMCI] Add possibility to convert object JavaConstant to jobject.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12882/head:pull/12882
$ git checkout pull/12882

Update a local copy of the PR:
$ git checkout pull/12882
$ git pull https://git.openjdk.org/jdk pull/12882/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12882

View PR using the GUI difftool:
$ git pr show -t 12882

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12882.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2023

👋 Welcome back tzezula! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 6, 2023

@tzezula The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 6, 2023
@tzezula tzezula changed the title [JVMCI] Add possibility to convert object JavaConstant to jobject. JDK-8303646: [JVMCI] Add possibility to convert object JavaConstant to jobject. Mar 6, 2023
@tzezula tzezula changed the title JDK-8303646: [JVMCI] Add possibility to convert object JavaConstant to jobject. JDK-8303678: [JVMCI] Add possibility to convert object JavaConstant to jobject. Mar 6, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 7, 2023

⚠️ @tzezula the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8303678
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@tzezula This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303678: [JVMCI] Add possibility to convert object JavaConstant to jobject.

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 98 new commits pushed to the master branch:

  • c313e1a: 8303922: build-test-lib target is broken
  • fbc76c2: 8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
  • a06426a: 8274400: HotSpot Style Guide should permit use of alignof
  • 98a7a60: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604
  • 0a4d54f: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out
  • 2116928: 8303900: Rename BitMap search functions
  • d7f4221: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode
  • 94de0a7: 8302513: remove sun.awt.util.IdentityLinkedList
  • bf16b5b: 8303937: Corrupted heap dumps due to missing retries for os::write()
  • 6f54eda: 8299088: ClassLoader::defineClass2 throws OOME but JNI exception pending thrown by getUTF
  • ... and 88 more: https://git.openjdk.org/jdk/compare/fa1cebedb5de10e34e9d0cd1d8a563c56b562f54...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tkrodriguez) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 7, 2023
@tzezula
Copy link
Author

tzezula commented Mar 13, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 13, 2023
@openjdk
Copy link

openjdk bot commented Mar 13, 2023

@tzezula
Your change (at version 3b9f27e) is now ready to be sponsored by a Committer.

@dougxc
Copy link
Member

dougxc commented Mar 13, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 13, 2023

Going to push as commit 1148a65.
Since your change was applied there have been 99 commits pushed to the master branch:

  • d20bde2: 8294715: Add IR checks to the reduction vectorization tests
  • c313e1a: 8303922: build-test-lib target is broken
  • fbc76c2: 8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
  • a06426a: 8274400: HotSpot Style Guide should permit use of alignof
  • 98a7a60: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604
  • 0a4d54f: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out
  • 2116928: 8303900: Rename BitMap search functions
  • d7f4221: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode
  • 94de0a7: 8302513: remove sun.awt.util.IdentityLinkedList
  • bf16b5b: 8303937: Corrupted heap dumps due to missing retries for os::write()
  • ... and 89 more: https://git.openjdk.org/jdk/compare/fa1cebedb5de10e34e9d0cd1d8a563c56b562f54...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 13, 2023
@openjdk openjdk bot closed this Mar 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 13, 2023
@openjdk
Copy link

openjdk bot commented Mar 13, 2023

@dougxc @tzezula Pushed as commit 1148a65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants