-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8303684: Lift upcall sharing mechanism to AbstractLinker (mainline) #12883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewed-by: mcimadamore
👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into |
@JornVernee The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (already reviewed on Panama repo)
@JornVernee This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@feilongjiang since this contains changes to the RISCV code as well, could you test the patch? Thanks. |
I'll submit a test on RISC-V board to see the results. It may take a while. Update: |
src/java.base/share/classes/jdk/internal/foreign/abi/aarch64/windows/WindowsAArch64Linker.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
/integrate |
Going to push as commit d4eb395. |
@JornVernee Pushed as commit d4eb395. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Port of: openjdk/panama-foreign#791 which lifts the sharing mechanism for upcall stubs to AbstractLinker.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12883/head:pull/12883
$ git checkout pull/12883
Update a local copy of the PR:
$ git checkout pull/12883
$ git pull https://git.openjdk.org/jdk pull/12883/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12883
View PR using the GUI difftool:
$ git pr show -t 12883
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12883.diff