Skip to content

8303684: Lift upcall sharing mechanism to AbstractLinker (mainline) #12883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Mar 6, 2023

Port of: openjdk/panama-foreign#791 which lifts the sharing mechanism for upcall stubs to AbstractLinker.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303684: Lift upcall sharing mechanism to AbstractLinker (mainline)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12883/head:pull/12883
$ git checkout pull/12883

Update a local copy of the PR:
$ git checkout pull/12883
$ git pull https://git.openjdk.org/jdk pull/12883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12883

View PR using the GUI difftool:
$ git pr show -t 12883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12883.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 6, 2023

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 6, 2023

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 6, 2023
@JornVernee JornVernee marked this pull request as ready for review March 8, 2023 16:52
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 8, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2023

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (already reviewed on Panama repo)

@openjdk
Copy link

openjdk bot commented Mar 8, 2023

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303684: Lift upcall sharing mechanism to AbstractLinker (mainline)

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 8, 2023
@JornVernee
Copy link
Member Author

@feilongjiang since this contains changes to the RISCV code as well, could you test the patch? Thanks.

@feilongjiang
Copy link
Member

feilongjiang commented Mar 10, 2023

I'll submit a test on RISC-V board to see the results. It may take a while.

Update:
jdk_foreign looks good on linux-riscv with release build.

Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 16, 2023

Going to push as commit d4eb395.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 16, 2023
@openjdk openjdk bot closed this Mar 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 16, 2023
@openjdk
Copy link

openjdk bot commented Mar 16, 2023

@JornVernee Pushed as commit d4eb395.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JornVernee JornVernee deleted the LazyUpcalls branch March 16, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants