8303622: JFR: Missing message with Objects.requireNonNull

[egahlin]

Could I have a review of a PR that adds a few missing message to Objects.requireNonNull for public API methods.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303622: JFR: Missing message with Objects.requireNonNull

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12885/head:pull/12885
$ git checkout pull/12885

Update a local copy of the PR:
$ git checkout pull/12885
$ git pull https://git.openjdk.org/jdk pull/12885/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12885

View PR using the GUI difftool:
$ git pr show -t 12885

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12885.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b617f62a)

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303622: JFR: Missing message with Objects.requireNonNull

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 43288bb: 8301477: Replace NULL with nullptr in os/aix
• 008c5eb: 8303621: BitMap::iterate should support lambdas and other function objects
• 52d3008: 8303497: [s390x] ProblemList TestUnreachableInnerLoop.java
• 3f2d929: 8303511: C2: assert(get_ctrl(n) == cle_out) during unrolling
• 7fbfc88: 8303534: Merge CompactibleSpace into ContiguousSpace
• 97c25df: 8204550: NMT: RegionIterator does not need to keep _current_size
• 94eda53: 8201516: DebugNonSafepoints generates incorrect information
• c51d40c: 8303607: SunMSCAPI provider leaks memory and keys
• f64ed09: 8303540: Eliminate unnecessary reference to javac internal class
• ccfe167: 8298939: Refactor open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.sh to jtreg java test
• ... and 7 more: https://git.openjdk.org/jdk/compare/8e2014527ead67ce33627a49223b8269a94f3102...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit 9b10c69.
Since your change was applied there have been 27 commits pushed to the master branch:

• d729824: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
• 5f1108f: 8303151: DCmd framework cleanups
• 32f4d8b: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null
• 9f9d678: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message
• b5b5cba: 8302801: Remove fdlibm C sources
• 4d4eade: 8302452: [JVMCI] Export _poly1305_processBlocks, JfrThreadLocal fields to JVMCI compiler.
• f1f4e1d: 6453901: (cal) clean up sun.util.calendar classes
• acf8996: 8303275: Use {@return and @linkplain in Locale and related classes
• ac3ab5b: 8217496: Matcher.group() can return null after usePattern
• 45a616a: 8303480: Miscellaneous fixes to mostly invisible doc comments
• ... and 17 more: https://git.openjdk.org/jdk/compare/8e2014527ead67ce33627a49223b8269a94f3102...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 9b10c69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.