8303495: Unused path parameter in ClassLoader::add_to_app_classpath_entries(JavaThread* current, char* path, ...)

[matias9927]

The path parameter is no longer used in the method ClassLoader::add_to_app_classpath_entries so it can be safely removed. Verified with tier 1-4 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303495: Unused path parameter in ClassLoader::add_to_app_classpath_entries(JavaThread* current, char* path, ...)

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12889/head:pull/12889
$ git checkout pull/12889

Update a local copy of the PR:
$ git checkout pull/12889
$ git pull https://git.openjdk.org/jdk pull/12889/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12889

View PR using the GUI difftool:
$ git pr show -t 12889

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12889.diff

[bridgekeeper]

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@matias9927 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (371543ab)

[calvinccheung]

Looks good and trivial.

[openjdk]

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303495: Unused path parameter in ClassLoader::add_to_app_classpath_entries(JavaThread* current, char* path, ...)

Reviewed-by: ccheung, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

• ddcb369: 8303605: Memory leaks in Metaspace gtests
• 56512cf: 8303682: Simplify HttpClient DebugLogger
• 8eaf84f: 8303575: adjust Xen handling on Linux aarch64
• d988252: 8303443: IGV: Syntax highlighting and resizing for filter editor
• afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
• 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
• 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
• 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
• 5fa9bd4: 8302189: Mark assertion failures noreturn
• 9b10c69: 8303622: JFR: Missing message with Objects.requireNonNull
• ... and 42 more: https://git.openjdk.org/jdk/compare/cd4b88d0d25958d3b5de2982233bc540ba5a4e3b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@calvinccheung, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dholmes-ora]

Looks good. Thanks

[matias9927]

Thanks for the reviews @calvinccheung and @dholmes-ora.
/integrate

[openjdk]

@matias9927
Your change (at version 371543a) is now ready to be sponsored by a Committer.

[coleenp]

/sponsor

[openjdk]

Going to push as commit c26e1d0.
Since your change was applied there have been 95 commits pushed to the master branch:

• 548d552: 8303548: Arguments::get_default_shared_archive_path() should cache the result for future use
• f2a36b4: 8302666: Replace CHM with VarHandle in ForeachOrderedTask
• a32ee5d: 8303949: gcc10 warning Linux ppc64le - note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
• 01312a0: 8300821: UB: Applying non-zero offset to non-null pointer 0xfffffffffffffffe produced null pointer
• 6d30bbe: 8303001: Add test for re-entrant upcalls
• de9f3b6: 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL
• b9951dd: 8303820: Simplify type metadata
• 75d6306: 8303349: Simplify link format for generic types in index pages
• b1d89f3: 8294971: jdk.jlink jdk.tools.jimage.JImageTask is using ASM to verify classes
• 0f26d09: 8303822: gtestMain should give more helpful output
• ... and 85 more: https://git.openjdk.org/jdk/compare/cd4b88d0d25958d3b5de2982233bc540ba5a4e3b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp @matias9927 Pushed as commit c26e1d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.