Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out #12896

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Mar 7, 2023

  • Fixed by increasing test timeout. Fix verified on host which reproduced issue.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12896/head:pull/12896
$ git checkout pull/12896

Update a local copy of the PR:
$ git checkout pull/12896
$ git pull https://git.openjdk.org/jdk pull/12896/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12896

View PR using the GUI difftool:
$ git pr show -t 12896

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12896.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2023

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 7, 2023
@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@sashamatveev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 7, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 11, 2023

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 127 new commits pushed to the master branch:

  • 2116928: 8303900: Rename BitMap search functions
  • d7f4221: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode
  • 94de0a7: 8302513: remove sun.awt.util.IdentityLinkedList
  • bf16b5b: 8303937: Corrupted heap dumps due to missing retries for os::write()
  • 6f54eda: 8299088: ClassLoader::defineClass2 throws OOME but JNI exception pending thrown by getUTF
  • a3358b1: 8303853: Update ISO 3166 country codes table
  • 206661d: 8281941: Change CDS warning messages to use Unified Logging
  • 9dd7b87: 8303674: JFR: TypeLibrary class not thread safe
  • c26e1d0: 8303495: Unused path parameter in ClassLoader::add_to_app_classpath_entries(JavaThread* current, char* path, ...)
  • 548d552: 8303548: Arguments::get_default_shared_archive_path() should cache the result for future use
  • ... and 117 more: https://git.openjdk.org/jdk/compare/f3abc4063de658418283aee1f552c4b4976e5211...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 11, 2023
@sashamatveev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 11, 2023

Going to push as commit 0a4d54f.
Since your change was applied there have been 127 commits pushed to the master branch:

  • 2116928: 8303900: Rename BitMap search functions
  • d7f4221: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode
  • 94de0a7: 8302513: remove sun.awt.util.IdentityLinkedList
  • bf16b5b: 8303937: Corrupted heap dumps due to missing retries for os::write()
  • 6f54eda: 8299088: ClassLoader::defineClass2 throws OOME but JNI exception pending thrown by getUTF
  • a3358b1: 8303853: Update ISO 3166 country codes table
  • 206661d: 8281941: Change CDS warning messages to use Unified Logging
  • 9dd7b87: 8303674: JFR: TypeLibrary class not thread safe
  • c26e1d0: 8303495: Unused path parameter in ClassLoader::add_to_app_classpath_entries(JavaThread* current, char* path, ...)
  • 548d552: 8303548: Arguments::get_default_shared_archive_path() should cache the result for future use
  • ... and 117 more: https://git.openjdk.org/jdk/compare/f3abc4063de658418283aee1f552c4b4976e5211...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2023
@openjdk openjdk bot closed this Mar 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2023
@openjdk
Copy link

openjdk bot commented Mar 11, 2023

@sashamatveev Pushed as commit 0a4d54f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants