Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8302508: Add timestamp to the output TraceCompilerThreads #12898

Closed
wants to merge 1 commit into from

Conversation

vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Mar 7, 2023

Having timestamps added to the output of TraceCompilerThreads will be helpful in understanding how frequently the compiler threads are being added or removed.

I did that and also added UL output.

java -XX:+TraceCompilerThreads -XX:+PrintCompilation -version

     86 Added initial compiler thread C2 CompilerThread0
     86 Added initial compiler thread C1 CompilerThread0
     92    1       3       java.lang.Object::<init> (1 bytes)
     96    2       3       java.lang.String::coder (15 bytes)

java -Xlog:jit+thread=debug -Xlog:jit+compilation=debug -version

[0.078s][debug][jit,thread] Added initial compiler thread C2 CompilerThread0
[0.078s][debug][jit,thread] Added initial compiler thread C1 CompilerThread0
[0.083s][debug][jit,compilation]    1       3       java.lang.Object::<init> (1 bytes)
[0.087s][debug][jit,compilation]    2       3       java.lang.String::coder (15 bytes)

Tested tier1.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8302508: Add timestamp to the output TraceCompilerThreads

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12898/head:pull/12898
$ git checkout pull/12898

Update a local copy of the PR:
$ git checkout pull/12898
$ git pull https://git.openjdk.org/jdk pull/12898/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12898

View PR using the GUI difftool:
$ git pr show -t 12898

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12898.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2023

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 7, 2023
@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@vnkozlov The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 7, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2023

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Mar 8, 2023

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302508: Add timestamp to the output TraceCompilerThreads

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
  • 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
  • 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
  • 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
  • 5fa9bd4: 8302189: Mark assertion failures noreturn
  • 9b10c69: 8303622: JFR: Missing message with Objects.requireNonNull
  • d729824: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls
  • 5f1108f: 8303151: DCmd framework cleanups
  • 32f4d8b: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null
  • 9f9d678: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message
  • ... and 15 more: https://git.openjdk.org/jdk/compare/ccfe1675a2a82accbca0ecd8bd6f1c167a1c06c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 8, 2023
@poonamparhar
Copy link
Member

The changes look good to me!

@vnkozlov
Copy link
Contributor Author

vnkozlov commented Mar 8, 2023

Thank you @TobiHartmann and @poonamparhar for reviews.

@vnkozlov
Copy link
Contributor Author

vnkozlov commented Mar 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 8, 2023

Going to push as commit f813dc7.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 404d5bd: 8302161: Upgrade jQuery UI to version 1.13.2
  • d287a5e: 8303617: update for deprecated sprintf for jdk.jdwp.agent
  • ddcb369: 8303605: Memory leaks in Metaspace gtests
  • 56512cf: 8303682: Simplify HttpClient DebugLogger
  • 8eaf84f: 8303575: adjust Xen handling on Linux aarch64
  • d988252: 8303443: IGV: Syntax highlighting and resizing for filter editor
  • afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
  • 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
  • 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
  • 21a6ab1: 8303799: [BACKOUT] JDK-8302801 Remove fdlibm C sources
  • ... and 21 more: https://git.openjdk.org/jdk/compare/ccfe1675a2a82accbca0ecd8bd6f1c167a1c06c6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 8, 2023
@openjdk openjdk bot closed this Mar 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2023
@openjdk
Copy link

openjdk bot commented Mar 8, 2023

@vnkozlov Pushed as commit f813dc7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov vnkozlov deleted the 8302508 branch March 8, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants