Skip to content

8303749: Serial: Use more strict card table API #12902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8303749: Serial: Use more strict card table API #12902

wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Mar 7, 2023 •
edited by openjdk bot
Loading

Simple refactoring to skip an unnecessary guard check.

Test: tier1-3

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12902/head:pull/12902
$ git checkout pull/12902

Update a local copy of the PR:
$ git checkout pull/12902
$ git pull https://git.openjdk.org/jdk pull/12902/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12902

View PR using the GUI difftool:
$ git pr show -t 12902

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12902.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8303749 8303749: Serial: Use more strict card table API Mar 7, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 7, 2023
@openjdk
Copy link

openjdk bot commented Mar 7, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Mar 7, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2023

Webrevs

tschatzl
tschatzl approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

src/hotspot/share/gc/serial/cardTableRS.cpp
}
invalidate(used_mr);
dirty_MemRegion(used_mr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that invalidate() isn't called any more, it might be useful to rename the method to dirty_or_clear() or something. In general I think that "dirty" is more specific and clear than "invalidate", but the "invalidate" term probably stems from wanting to be generic (not only here).
So feel free to ignore this suggestions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear_into_younger and invalidate_or_clear/dirty_or_clear are not very descriptive. I will refactor them in another PR.

@openjdk
Copy link

openjdk bot commented Mar 8, 2023 •
edited
Loading

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303749: Serial: Use more strict card table API

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 138 new commits pushed to the master branch:

  • 7277bb1: 8293324: ciField.hpp has two methods to return field's offset
  • b7945bc: 8303154: Investigate and improve instruction cache flushing during compilation
  • eefbaa2: 8283400: [macos] a11y : Screen magnifier does not reflect JRadioButton value change
  • 42dd907: 8302906: AArch64: Add SVE backend support for vector unsigned comparison
  • 2b81fae: 8303022: "assert(allocates2(pc)) failed: not in CodeBuffer memory" When linking downcall handle
  • be08a25: 8304264: Debug messages always show up for NativeGSS
  • 1ae69e3: 8304287: Problemlist java/net/SocketOption/OptionsTest.java
  • 116627d: 8304267: JDK-8303415 missed change in Zero Interpreter
  • 824a5e4: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates
  • 7ad48ea: 8300317: vmTestbase/nsk/stress/strace/strace* tests fail with "ERROR: wrong lengths of stack traces"
  • ... and 128 more: https://git.openjdk.org/jdk/compare/7fbfc884f0980169e8c08167d59147222728b66b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 8, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 16, 2023

Going to push as commit b5108b4.
Since your change was applied there have been 141 commits pushed to the master branch:

  • 7dbab81: 8304161: Add TypeKind.from to derive from TypeDescriptor.OfField
  • d4eb395: 8303684: Lift upcall sharing mechanism to AbstractLinker (mainline)
  • dfc7214: 8304283: Modernize the switch statements in jdk.internal.foreign
  • 7277bb1: 8293324: ciField.hpp has two methods to return field's offset
  • b7945bc: 8303154: Investigate and improve instruction cache flushing during compilation
  • eefbaa2: 8283400: [macos] a11y : Screen magnifier does not reflect JRadioButton value change
  • 42dd907: 8302906: AArch64: Add SVE backend support for vector unsigned comparison
  • 2b81fae: 8303022: "assert(allocates2(pc)) failed: not in CodeBuffer memory" When linking downcall handle
  • be08a25: 8304264: Debug messages always show up for NativeGSS
  • 1ae69e3: 8304287: Problemlist java/net/SocketOption/OptionsTest.java
  • ... and 131 more: https://git.openjdk.org/jdk/compare/7fbfc884f0980169e8c08167d59147222728b66b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 16, 2023
@openjdk openjdk bot closed this Mar 16, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 16, 2023
@openjdk
Copy link

openjdk bot commented Mar 16, 2023

@albertnetymk Pushed as commit b5108b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the s1-clear-memregion branch March 16, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschatzl tschatzl tschatzl approved these changes

@walulyai walulyai walulyai approved these changes

Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertnetymk @tschatzl @walulyai