8282201: Consider removal of expiry check in VerifyCACerts.java test

[rhalade]

This fix removes the check for 90 days expiry. But the test will continue to fail if the expired certificate is included in cacerts but no exception is granted.

Fix also includes minor code cleanup.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8282201: Consider removal of expiry check in VerifyCACerts.java test

Reviewers

• Xue-Lei Andrew Fan (@XueleiFan - Reviewer) ⚠️ Review applies to 070b4124
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12910/head:pull/12910
$ git checkout pull/12910

Update a local copy of the PR:
$ git checkout pull/12910
$ git pull https://git.openjdk.org/jdk pull/12910/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12910

View PR using the GUI difftool:
$ git pr show -t 12910

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12910.diff

[bridgekeeper]

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[rhalade]

@seanjmullan 90 days expiry check is removed but test will continue to check expiry exception. This allows extra time to consider removal of root.

[openjdk]

@rhalade The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (26351330)
• 00: Full (070b4124)

[XueleiFan]

If the check get removed, how could the expired cert get caught in the future?

[rhalade]

The fix removes the early warning (90 days). Usually this is very early and only fix is to add certificate to expiry exception. Test would still fail when a expired certificate is included but no exception is granted. I have filed tracking bugs for next few years with due date so we don't miss any.

[openjdk]

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282201: Consider removal of expiry check in VerifyCACerts.java test

Reviewed-by: xuelei, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• f813dc7: 8302508: Add timestamp to the output TraceCompilerThreads
• 404d5bd: 8302161: Upgrade jQuery UI to version 1.13.2
• d287a5e: 8303617: update for deprecated sprintf for jdk.jdwp.agent
• ddcb369: 8303605: Memory leaks in Metaspace gtests
• 56512cf: 8303682: Simplify HttpClient DebugLogger
• 8eaf84f: 8303575: adjust Xen handling on Linux aarch64
• d988252: 8303443: IGV: Syntax highlighting and resizing for filter editor
• afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
• 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
• 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
• ... and 9 more: https://git.openjdk.org/jdk/compare/f1f4e1de445cbec44f871791e93d4dd566c232f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[rhalade]

/integrate

[openjdk]

Going to push as commit 5b43804.
Since your change was applied there have been 19 commits pushed to the master branch:

• f813dc7: 8302508: Add timestamp to the output TraceCompilerThreads
• 404d5bd: 8302161: Upgrade jQuery UI to version 1.13.2
• d287a5e: 8303617: update for deprecated sprintf for jdk.jdwp.agent
• ddcb369: 8303605: Memory leaks in Metaspace gtests
• 56512cf: 8303682: Simplify HttpClient DebugLogger
• 8eaf84f: 8303575: adjust Xen handling on Linux aarch64
• d988252: 8303443: IGV: Syntax highlighting and resizing for filter editor
• afda8fb: 8303136: MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded005 failed with "isCollectionUsageThresholdExceeded() returned true, while threshold = 1 and used = 0"
• 1d071d0: 8303690: Prefer ArrayList to LinkedList in com.sun.jmx.mbeanserver.Introspector
• 09d469e: 8252255: Blurry rendering of SwingNode with HiDPI scaling in JavaFX
• ... and 9 more: https://git.openjdk.org/jdk/compare/f1f4e1de445cbec44f871791e93d4dd566c232f1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rhalade Pushed as commit 5b43804.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.