Skip to content

8303001: Add test for re-entrant upcalls #12927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Mar 8, 2023

Add a test that tests re-entrant upcalls, which is a use-case that is uncovered by testing until now.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12927/head:pull/12927
$ git checkout pull/12927

Update a local copy of the PR:
$ git checkout pull/12927
$ git pull https://git.openjdk.org/jdk pull/12927/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12927

View PR using the GUI difftool:
$ git pr show -t 12927

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12927.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2023

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 8, 2023

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Mar 8, 2023
@JornVernee JornVernee marked this pull request as ready for review March 9, 2023 15:54
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 9, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 9, 2023

Webrevs

Copy link
Contributor

@mcimadamore mcimadamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test!

@openjdk
Copy link

openjdk bot commented Mar 9, 2023

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303001: Add test for re-entrant upcalls

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 3227b49: 8303760: Visual Studio should use the primary variant in the IDE
  • cdcf5c1: 8303702: Provide ThreadFactory to create platform/virtual threads for com/sun/jdi tests
  • 4655b79: 8294982: Implementation of Classfile API
  • 1e9942a: 8303881: Mixed, minor cleanup in jdk.compiler
  • 7e01534: 8303467: Serial: Refactor reference processor
  • 713def0: 8303105: LoopRangeStrideTest fails IR verification on x86
  • 34a9246: 8274264: Not all of G1 young collection verification honors the verification type
  • a7e308a: 8303576: addIdentitiesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return
  • dd79410: 8303509: Socket setTrafficClass does not work for IPv4 connections when IPv6 enabled
  • dc523a5: 8300258: C2: vectorization fails on simple ByteBuffer loop
  • ... and 2 more: https://git.openjdk.org/jdk/compare/02875e77fd01c39aee6f2f0900ea5605b40a8780...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 9, 2023
@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2023

Going to push as commit 6d30bbe.
Since your change was applied there have been 30 commits pushed to the master branch:

  • de9f3b6: 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL
  • b9951dd: 8303820: Simplify type metadata
  • 75d6306: 8303349: Simplify link format for generic types in index pages
  • b1d89f3: 8294971: jdk.jlink jdk.tools.jimage.JImageTask is using ASM to verify classes
  • 0f26d09: 8303822: gtestMain should give more helpful output
  • e26cc52: 8303624: The java.lang.Thread.FieldHolder can be null for JNI attaching threads
  • d06308c: 8302360: Atomic*.compareAndExchange Javadoc unclear
  • 8b740b4: 8302779: HelidonAppTest.java fails with "assert(_cb == CodeCache::find_blob(pc())) failed: Must be the same" or SIGSEGV
  • 562c8fc: 8303691: Fedora based devkit build should load more packages from archive location
  • e930b63: 8303924: ProblemList serviceability/sa/UniqueVtableTest.java on Linux
  • ... and 20 more: https://git.openjdk.org/jdk/compare/02875e77fd01c39aee6f2f0900ea5605b40a8780...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2023
@openjdk openjdk bot closed this Mar 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2023
@openjdk
Copy link

openjdk bot commented Mar 10, 2023

@JornVernee Pushed as commit 6d30bbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JornVernee JornVernee deleted the ReentrantUpcalls branch March 10, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants