8303830: update for deprecated sprintf for jdk.accessibility

[XueleiFan]

Hi,

May I have this update reviewed?

The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of security concerns. The issue was addressed in JDK-8296812 for building failure, and JDK-8299378/JDK-8299635/JDK-8301132 for testing issues . This is a break-down update for sprintf uses in the jdk.accessibility module.

Thanks,
Xuelei

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303830: update for deprecated sprintf for jdk.accessibility

Reviewers

• Alexander Zuev (@azuev-java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12929/head:pull/12929
$ git checkout pull/12929

Update a local copy of the PR:
$ git checkout pull/12929
$ git pull https://git.openjdk.org/jdk.git pull/12929/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12929

View PR using the GUI difftool:
$ git pr show -t 12929

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12929.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@XueleiFan The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (933e57e0)

[XueleiFan]

ping ...

[prrace]

Looks reasonable .. how did you test it ? Please do NOT tell me its obvious and safe.
@azuev-java please review.

[XueleiFan]

how did you test it ?
The existing regression tests will be used for the testing. I will ask for a Mach5 testing if approved. Hopefully, the current regression test coverage is sufficient. I have no plan to add new test cases.

[prrace]

how did you test it ?
The existing regression tests will be used for the testing. I will ask for a Mach5 testing if approved. Hopefully, the current regression test coverage is sufficient. I have no plan to add new test cases.

This is windowsaccessbridge which isn't loaded by JDK, its loaded by the AT.
So tested only if you have JAWS or an to test with SFAIK.
And jaccessinspector and jaccesswalker are separate tools in the JDK.
I think you'd have to be doing the manual accessibility testing.
In other words, you aren't testing the changes you propose.
The automated regression tests SFAIK will not prove anything.

Its important to understand the code you are changing and how it is used - not just to know C functions.
There's mention of this on our group page :-
https://openjdk.org/groups/client-libs/
See the paragraph : "Be a subject matter expert, not just a language expert."

Alex Zuev or @kumarabhi006 can you advise on testing, or failing that test it yourself.

[azuev-java]

The problem with testing of this code is that a lot of it (if not all) is inside the debug and logging part, which means that not only library should be loaded (doable) and the debug is on (also doable) but some of that code is just an error report and in order to cause system to misbehave enough to cause such error is not trivial. Looking into it though.

[azuev-java]

I tested this change on Windows using JAWS and built in jaccesswalker and jaccessinspector and found no problems caused by this change.

[openjdk]

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303830: update for deprecated sprintf for jdk.accessibility

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 754 new commits pushed to the master branch:

• 197d0cc: 8294983: SSLEngine throws ClassCastException during handshake
• a87262e: 8307295: Add warning to not create new ACC flags
• 0c6529d: 8307156: native_thread not protected by TLH
• 5ca0b08: 8307133: Open source some JTable jtreg tests
• 2adb3b4: 8306943: Open source several dnd AWT tests
• dc4096c: 8304937: BufferedFieldBuilder.Model missing writeTo(DirectClassBuilder)
• 29233e0: 8307448: Test RedefineSharedClassJFR fail due to wrong assumption
• 408cec5: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
• cecf817: 8307181: MemoryLayout.structLayout uses undocumented strict alignment constraints
• 3f1927a: 8307346: Add missing gc+phases logging for ObjectCount(AfterGC) JFR event collection code
• ... and 744 more: https://git.openjdk.org/jdk/compare/d287a5e9d8e1b87397694781772c4ddbf5e4f4a4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[XueleiFan]

@azuev-java Thank you very much for helping the testing. Are two reviewers required for client lib PR review?

[XueleiFan]

/integrate

[openjdk]

Going to push as commit 44fa12e.
Since your change was applied there have been 820 commits pushed to the master branch:

• fdbfc8a: 8133773: clarify specification of Spliterator.tryAdvance
• 5842fd5: 8306015: Update sun.security.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate
• 672bade: 8306738: Select num workers for safepoint ParallelCleanupTask
• a05560d: 8305990: Stripping debug info of ASM 9.5 fails
• 040cb7b: 8307588: [JVMCI] HotSpotConstantPool#lookupBootstrapMethodInvocation broken by JDK-8301995
• f92d095: 8307411: Test java/foreign/channels/TestAsyncSocketChannels.java failed: IllegalStateException: Already closed
• 7a3bea1: 8307629: FunctionDescriptor::toMethodType should allow sequence layouts (mainline)
• d2b3eef: 8307131: C2: assert(false) failed: malformed control flow
• cd5d0ff: 8304031: Classfile API cannot encode Primitive Class as Condy
• 07f55c5: 8305950: Have -XshowSettings option display tzdata version
• ... and 810 more: https://git.openjdk.org/jdk/compare/d287a5e9d8e1b87397694781772c4ddbf5e4f4a4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@XueleiFan Pushed as commit 44fa12e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.