8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp #12941

reinrich · 2023-03-09T10:46:05Z

Mark a frame as not fully initialized when copying it from a continuation StackChunk to the stack until the callers_sp (aka back link) is set.

This avoids the assertion given in the bug report when the copied frame is deoptimized before it is fully initialized.
IMHO the deoptimization at that point is a little questionable but it actually only changes the pc of the frame which can be done.
Note that the frame can get extended later (and metadata can get overridden) but there is code that handles this.

Testing: jdk_loom. The fix passed our CI testing. This includes most JCK and JTREG tiers 1-4, also in Xcomp mode, on the standard platforms and also on ppc64le.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp

Reviewers

Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12941/head:pull/12941
$ git checkout pull/12941

Update a local copy of the PR:
$ git checkout pull/12941
$ git pull https://git.openjdk.org/jdk pull/12941/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12941

View PR using the GUI difftool:
$ git pr show -t 12941

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12941.diff

bridgekeeper · 2023-03-09T10:47:59Z

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-03-09T10:51:15Z

@reinrich The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

reinrich · 2023-03-09T12:30:16Z

/label hotspot-compiler

reinrich · 2023-03-09T12:30:31Z

/label remove hotspot

openjdk · 2023-03-09T12:32:09Z

@reinrich
The hotspot-compiler label was successfully added.

openjdk · 2023-03-09T12:33:32Z

@reinrich
The hotspot label was successfully removed.

mlbridge · 2023-03-14T10:17:44Z

Webrevs

01: Full - Incremental (1a283f73)
00: Full (4188e822)

TheRealMDoerr

This looks good. Seems like we should update Copyright years.

TheRealMDoerr · 2023-03-15T08:59:22Z

src/hotspot/cpu/ppc/frame_ppc.hpp

@@ -379,6 +386,9 @@
  int offset_fp() const         { assert_offset();  return _offset_fp; }
  void set_offset_fp(int value) { assert_on_heap(); _offset_fp = value; }

+  // Mark a frame as not fully initialized


Maybe add a comment like "Must not be used for frames in the valid back chain."?

Thanks for the feedback. I've added the comment and updated the Copyright years.

TheRealMDoerr

Thanks!

openjdk · 2023-03-15T09:20:41Z

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 137 new commits pushed to the master branch:

349139b: 8304030: Configure call fails on AIX when using --with-gtest option.
714b5f0: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class
065d3e0: 8304171: Fix layout of JCov instrumented bundle on Mac OS
cd41c69: 8303705: Field sleeper.started should be volatile JdbLockTestTarg.java
f5c8b68: 8301998: Update HarfBuzz to 7.0.1
617c15f: 8304172: ProblemList serviceability/sa/UniqueVtableTest.java
f81e1de: 8303882: Refactor some iterators in jdk.compiler
45809fd: 8295884: Implement IDE support for Eclipse
baf11e7: 8303814: getLastErrorString should avoid charset conversions
830fd41: 8302795: Shared archive failed on old version class with jsr bytecode
... and 127 more: https://git.openjdk.org/jdk/compare/8e2014527ead67ce33627a49223b8269a94f3102...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

reinrich · 2023-03-17T08:44:00Z

/integrate

openjdk · 2023-03-17T08:45:26Z

Going to push as commit 9d518c5.
Since your change was applied there have been 164 commits pushed to the master branch:

ebac7ee: 8304063: tools/jpackage/share/AppLauncherEnvTest.java fails when checking LD_LIBRARY_PATH
36995c5: 8304242: CPUInfoTest fails because "serialize" CPU feature is not known
6b42275: 7154070: in SwingSet2, switching between LaFs it's easy to lose JTable dividers
8eed7de: 8304146: Refactor VisibleMemberTable (LocalMemberTable)
a487a27: 8303150: DCmd framework unnecessarily creates a DCmd instance on registration
2e987d7: 8304360: Test to ensure ConstantDescs fields work
2f23c80: 8304225: Remove javax/script/Test7.java from ProblemList
96889bf: 8191565: Last-ditch Full GC should also move humongous objects
f629152: 8304055: G1: Remove OldGCAllocRegion::release
b5108b4: 8303749: Serial: Use more strict card table API
... and 154 more: https://git.openjdk.org/jdk/compare/8e2014527ead67ce33627a49223b8269a94f3102...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-03-17T08:45:46Z

@reinrich Pushed as commit 9d518c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Fix

4188e82

openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 9, 2023

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Mar 9, 2023

openjdk bot removed the hotspot hotspot-dev@openjdk.org label Mar 9, 2023

reinrich marked this pull request as ready for review March 9, 2023 13:27

reinrich changed the title ~~Fix~~ 8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp Mar 14, 2023

openjdk bot added the rfr Pull request is ready for review label Mar 14, 2023

TheRealMDoerr reviewed Mar 15, 2023

View reviewed changes

Feedback Martin

1a283f7

TheRealMDoerr approved these changes Mar 15, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 15, 2023

openjdk bot added the integrated Pull request has been integrated label Mar 17, 2023

openjdk bot closed this Mar 17, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2023

reinrich deleted the 8299375_ppc_deopt_during_thaw_issues branch January 24, 2025 08:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp #12941

8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp #12941

reinrich commented Mar 9, 2023 •

edited by openjdk bot

Loading

bridgekeeper bot commented Mar 9, 2023

openjdk bot commented Mar 9, 2023

reinrich commented Mar 9, 2023

reinrich commented Mar 9, 2023

openjdk bot commented Mar 9, 2023

openjdk bot commented Mar 9, 2023

mlbridge bot commented Mar 14, 2023 •

edited

Loading

TheRealMDoerr left a comment •

edited

Loading

TheRealMDoerr Mar 15, 2023

reinrich Mar 15, 2023

TheRealMDoerr left a comment

openjdk bot commented Mar 15, 2023

reinrich commented Mar 17, 2023

openjdk bot commented Mar 17, 2023

openjdk bot commented Mar 17, 2023

8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp #12941

8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp #12941

Conversation

reinrich commented Mar 9, 2023 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Mar 9, 2023

openjdk bot commented Mar 9, 2023

reinrich commented Mar 9, 2023

reinrich commented Mar 9, 2023

openjdk bot commented Mar 9, 2023

openjdk bot commented Mar 9, 2023

mlbridge bot commented Mar 14, 2023 • edited Loading

Webrevs

TheRealMDoerr left a comment • edited Loading

Choose a reason for hiding this comment

TheRealMDoerr Mar 15, 2023

Choose a reason for hiding this comment

reinrich Mar 15, 2023

Choose a reason for hiding this comment

TheRealMDoerr left a comment

Choose a reason for hiding this comment

openjdk bot commented Mar 15, 2023

reinrich commented Mar 17, 2023

openjdk bot commented Mar 17, 2023

openjdk bot commented Mar 17, 2023

reinrich commented Mar 9, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Mar 14, 2023 •

edited

Loading

TheRealMDoerr left a comment •

edited

Loading