8303883: Confusing parameter name in G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes

[tschatzl]

Hi all,

please review this change to de-confuse (imo) a parameter in G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes.

I also replaced some SIZE_FORMAT in the vicinity.

Testing: local jtreg gc test, GHA

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303883: Confusing parameter name in G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer) ⚠️ Review applies to e496ad94
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12947/head:pull/12947
$ git checkout pull/12947

Update a local copy of the PR:
$ git checkout pull/12947
$ git pull https://git.openjdk.org/jdk pull/12947/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12947

View PR using the GUI difftool:
$ git pr show -t 12947

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12947.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (fcf1916f)
• 00: Full (e496ad94)

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303883: Confusing parameter name in G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• 25e7ac2: 8294966: Convert jdk.jartool/sun.tools.jar.FingerPrint to use the ClassFile API to parse JAR entries
• 3018b47: 8303969: Limit printed failures within an object during G1 heap verification
• b575e54: 8303963: Replace various encodings of UINT/SIZE_MAX in gc code
• c183fce: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms
• 31e1e39: 8303646: [JVMCI] Add possibility to lookup ResolvedJavaType from jclass.
• 1148a65: 8303678: [JVMCI] Add possibility to convert object JavaConstant to jobject.
• d20bde2: 8294715: Add IR checks to the reduction vectorization tests
• c313e1a: 8303922: build-test-lib target is broken
• fbc76c2: 8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
• a06426a: 8274400: HotSpot Style Guide should permit use of alignof
• ... and 40 more: https://git.openjdk.org/jdk/compare/34a92466a615415b76c8cb6010ff7e6e1a1d63b4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[walulyai]

Lgtm!

[tschatzl]

Thanks @albertnetymk @walulyai for your reviews
/integrate

[openjdk]

Going to push as commit 805a4e6.
Since your change was applied there have been 50 commits pushed to the master branch:

• 25e7ac2: 8294966: Convert jdk.jartool/sun.tools.jar.FingerPrint to use the ClassFile API to parse JAR entries
• 3018b47: 8303969: Limit printed failures within an object during G1 heap verification
• b575e54: 8303963: Replace various encodings of UINT/SIZE_MAX in gc code
• c183fce: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms
• 31e1e39: 8303646: [JVMCI] Add possibility to lookup ResolvedJavaType from jclass.
• 1148a65: 8303678: [JVMCI] Add possibility to convert object JavaConstant to jobject.
• d20bde2: 8294715: Add IR checks to the reduction vectorization tests
• c313e1a: 8303922: build-test-lib target is broken
• fbc76c2: 8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
• a06426a: 8274400: HotSpot Style Guide should permit use of alignof
• ... and 40 more: https://git.openjdk.org/jdk/compare/34a92466a615415b76c8cb6010ff7e6e1a1d63b4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 805a4e6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.