8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604

[feilongjiang]

JDK-8303604 fixes an issue with passing structs whose size is not a power of two on SysV and AArch64 platforms. The same issue happens on RISC-V.

Modifications are unnecessary for STRUCT_REGISTER_F and STRUCT_REGISTER_XF. If there are no available registers, they will fall back to STRUCT_REGISTER_X.

Testing:

• TestArrayStructs.java
• jdk_foreign on Unmatched Board (release build)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604

Reviewers

• Jorn Vernee (@JornVernee - Reviewer)
• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12950/head:pull/12950
$ git checkout pull/12950

Update a local copy of the PR:
$ git checkout pull/12950
$ git pull https://git.openjdk.org/jdk pull/12950/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12950

View PR using the GUI difftool:
$ git pr show -t 12950

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12950.diff

[bridgekeeper]

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@feilongjiang The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8bd2e6bc)

[JornVernee]

LGTM

[openjdk]

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604

Reviewed-by: jvernee, fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 0a4d54f: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out
• 2116928: 8303900: Rename BitMap search functions
• d7f4221: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode
• 94de0a7: 8302513: remove sun.awt.util.IdentityLinkedList
• bf16b5b: 8303937: Corrupted heap dumps due to missing retries for os::write()
• 6f54eda: 8299088: ClassLoader::defineClass2 throws OOME but JNI exception pending thrown by getUTF
• a3358b1: 8303853: Update ISO 3166 country codes table
• 206661d: 8281941: Change CDS warning messages to use Unified Logging
• 9dd7b87: 8303674: JFR: TypeLibrary class not thread safe
• c26e1d0: 8303495: Unused path parameter in ClassLoader::add_to_app_classpath_entries(JavaThread* current, char* path, ...)
• ... and 26 more: https://git.openjdk.org/jdk/compare/1e9942aa112edca33f964db127df6c9ce41e86ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee, @RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[RealFYang]

Looks fine to me.

[feilongjiang]

@JornVernee @RealFYang -- Thanks!
/integrate

[openjdk]

@feilongjiang
Your change (at version 8bd2e6b) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 98a7a60.
Since your change was applied there have been 36 commits pushed to the master branch:

• 0a4d54f: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out
• 2116928: 8303900: Rename BitMap search functions
• d7f4221: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode
• 94de0a7: 8302513: remove sun.awt.util.IdentityLinkedList
• bf16b5b: 8303937: Corrupted heap dumps due to missing retries for os::write()
• 6f54eda: 8299088: ClassLoader::defineClass2 throws OOME but JNI exception pending thrown by getUTF
• a3358b1: 8303853: Update ISO 3166 country codes table
• 206661d: 8281941: Change CDS warning messages to use Unified Logging
• 9dd7b87: 8303674: JFR: TypeLibrary class not thread safe
• c26e1d0: 8303495: Unused path parameter in ClassLoader::add_to_app_classpath_entries(JavaThread* current, char* path, ...)
• ... and 26 more: https://git.openjdk.org/jdk/compare/1e9942aa112edca33f964db127df6c9ce41e86ff...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @feilongjiang Pushed as commit 98a7a60.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.