8303900: Rename BitMap search functions

[kimbarrett]

Please review this renaming of the following functions in BitMap:

get_next_one_offset => find_first_set_bit
get_next_zero_offset => find_first_clear_bit
get_next_one_offset_aligned_right => find_first_set_bit_aligned_right

Note that ShenandoahMarkBitMap::get_next_one_offset is not being renamed. For
some reason that class contains a copy of a sizable chunk of the code from
some version of BitMap. (Not sure why it doesn't use an internal BitMapView
rather than code copying.)

Testing:
mach5 tier1-5

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303900: Rename BitMap search functions

Reviewers

• Stefan Karlsson (@stefank - Reviewer) ⚠️ Review applies to 94fa65a5
• Axel Boldt-Christmas (@xmas92 - Committer) ⚠️ Review applies to 94fa65a5

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12951/head:pull/12951
$ git checkout pull/12951

Update a local copy of the PR:
$ git checkout pull/12951
$ git pull https://git.openjdk.org/jdk pull/12951/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12951

View PR using the GUI difftool:
$ git pr show -t 12951

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12951.diff

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett The following labels will be automatically applied to this pull request:

• hotspot
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c503e584)
• 00: Full (94fa65a5)

[stefank]

Looks good.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303900: Rename BitMap search functions

Reviewed-by: stefank, aboldtch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[xmas92]

lgtm

[kimbarrett]

Thanks for reviews @stefank and @xmas92

[kimbarrett]

/integrate

[openjdk]

Going to push as commit 2116928.

[openjdk]

@kimbarrett Pushed as commit 2116928.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.