8303915: javadoc build failure after JDK-8294959

[asotona]

Newly added Classfile API is based on pattern matching preview feature.
Unfortunately standard tier1 - 3 tests execution does not involve javadoc generation and so it didn't discover missing preview option.

Please review this patch enabling preview for javadoc generation, until pattern matching is finalized.

Thank you,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303915: javadoc build failure after JDK-8294959

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12957/head:pull/12957
$ git checkout pull/12957

Update a local copy of the PR:
$ git checkout pull/12957
$ git pull https://git.openjdk.org/jdk pull/12957/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12957

View PR using the GUI difftool:
$ git pr show -t 12957

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12957.diff

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303915: javadoc build failure after JDK-8294959

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• f9aadb9: 8303489: Add a test to verify classes in vmStruct have unique vtables

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[asotona]

/integrate

[dcubed-ojdk]

Unfortunately standard tier1 - 3 tests execution does not involve javadoc generation...

I'm not sure what this sentence means since this build failure was caught with
a standard Mach5 Tier1 job set, i.e., mach5 -j tier1 ...

[openjdk]

Going to push as commit 769e740.
Since your change was applied there has been 1 commit pushed to the master branch:

• f9aadb9: 8303489: Add a test to verify classes in vmStruct have unique vtables

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit 769e740.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mlbridge]

Webrevs

• 00: Full (3a74047c)

[asotona]

Unfortunately standard tier1 - 3 tests execution does not involve javadoc generation...

I'm not sure what this sentence means since this build failure was caught with a standard Mach5 Tier1 job set, i.e., mach5 -j tier1 ...

Oh, than I have to find out where I made mistake with Mach5 tests.
Thank you and I apologize for this inconvenience.