8303922: build-test-lib target is broken

[eirbjo]

The Make target 'build-test-lib-target' is broken in a few ways:

• make/test/BuildTestLib.gmk references the directory $(TEST_LIB_SOURCE_DIR)/sun which does not seem to exist. This can be fixed by removing the reference.
• Some test-lib sources use preview-features which is not enabled by make/test/BuildTestLib.gmk. This is fixed by adding a JAVAC_FLAGS with --enable-preview and also adding 'preview' to DISABLED_WARNINGS
• ASN1Formatter.annotate has a possible lossy conversion from long to int which can be fixed by adding an explicit cast

This PR fixes the above issues.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303922: build-test-lib target is broken

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12960/head:pull/12960
$ git checkout pull/12960

Update a local copy of the PR:
$ git checkout pull/12960
$ git pull https://git.openjdk.org/jdk pull/12960/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12960

View PR using the GUI difftool:
$ git pr show -t 12960

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12960.diff

[bridgekeeper]

👋 Welcome back eirbjo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@eirbjo The following labels will be automatically applied to this pull request:

• build
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1eef8ebc)

[openjdk]

@eirbjo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303922: build-test-lib target is broken

Reviewed-by: erikj, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 189 new commits pushed to the master branch:

• fbc76c2: 8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
• a06426a: 8274400: HotSpot Style Guide should permit use of alignof
• 98a7a60: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604
• 0a4d54f: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out
• 2116928: 8303900: Rename BitMap search functions
• d7f4221: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode
• 94de0a7: 8302513: remove sun.awt.util.IdentityLinkedList
• bf16b5b: 8303937: Corrupted heap dumps due to missing retries for os::write()
• 6f54eda: 8299088: ClassLoader::defineClass2 throws OOME but JNI exception pending thrown by getUTF
• a3358b1: 8303853: Update ISO 3166 country codes table
• ... and 179 more: https://git.openjdk.org/jdk/compare/f2b03f9a2c0fca853211e41a1ddf46195dd56698...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @TheShermanTanker) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[eirbjo]

/integrate

[openjdk]

@eirbjo
Your change (at version 1eef8eb) is now ready to be sponsored by a Committer.

[TheShermanTanker]

Looks ok to me, good work :)

[TheShermanTanker]

/sponsor

[openjdk]

Going to push as commit c313e1a.
Since your change was applied there have been 189 commits pushed to the master branch:

• fbc76c2: 8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
• a06426a: 8274400: HotSpot Style Guide should permit use of alignof
• 98a7a60: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604
• 0a4d54f: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out
• 2116928: 8303900: Rename BitMap search functions
• d7f4221: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode
• 94de0a7: 8302513: remove sun.awt.util.IdentityLinkedList
• bf16b5b: 8303937: Corrupted heap dumps due to missing retries for os::write()
• 6f54eda: 8299088: ClassLoader::defineClass2 throws OOME but JNI exception pending thrown by getUTF
• a3358b1: 8303853: Update ISO 3166 country codes table
• ... and 179 more: https://git.openjdk.org/jdk/compare/f2b03f9a2c0fca853211e41a1ddf46195dd56698...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker @eirbjo Pushed as commit c313e1a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.