Skip to content

8303924: ProblemList serviceability/sa/UniqueVtableTest.java on Linux#12962

Closed
alexmenkov wants to merge 1 commit intoopenjdk:masterfrom
alexmenkov:vtable_test_pl
Closed

8303924: ProblemList serviceability/sa/UniqueVtableTest.java on Linux#12962
alexmenkov wants to merge 1 commit intoopenjdk:masterfrom
alexmenkov:vtable_test_pl

Conversation

@alexmenkov
Copy link

@alexmenkov alexmenkov commented Mar 9, 2023

The test fails intermittently on linux-x64-debug and linux-aarch64-debug


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303924: ProblemList serviceability/sa/UniqueVtableTest.java on Linux

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12962/head:pull/12962
$ git checkout pull/12962

Update a local copy of the PR:
$ git checkout pull/12962
$ git pull https://git.openjdk.org/jdk pull/12962/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12962

View PR using the GUI difftool:
$ git pr show -t 12962

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12962.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 9, 2023

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 9, 2023
@openjdk
Copy link

openjdk bot commented Mar 9, 2023

@alexmenkov To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@alexmenkov
Copy link
Author

/label add serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Mar 9, 2023
@openjdk
Copy link

openjdk bot commented Mar 9, 2023

@alexmenkov
The serviceability label was successfully added.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@openjdk
Copy link

openjdk bot commented Mar 9, 2023

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303924: ProblemList serviceability/sa/UniqueVtableTest.java on Linux

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5726d31: 8301074: Replace NULL with nullptr in share/opto/

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 9, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 9, 2023

Webrevs

@alexmenkov
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 9, 2023

Going to push as commit e930b63.
Since your change was applied there have been 3 commits pushed to the master branch:

  • af0ca78: 8303609: ProblemList serviceability/sa/TestSysProps.java with ZGC
  • 8b0eb72: 8289765: JDI EventSet/resume/resume008 failed with "ERROR: suspendCounts don't match for : VirtualThread-unparker"
  • 5726d31: 8301074: Replace NULL with nullptr in share/opto/

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 9, 2023
@openjdk openjdk bot closed this Mar 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 9, 2023
@openjdk
Copy link

openjdk bot commented Mar 9, 2023

@alexmenkov Pushed as commit e930b63.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the vtable_test_pl branch March 9, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants