8303548: Arguments::get_default_shared_archive_path() should cache the result for future use

[matias9927]

The method Arguments::get_default_shared_archive_path() generates a string containing a path every time it is called. Since this method is idempotent, the string only needs to be constructed once in the lifetime of the VM. This change caches the result of Arguments::get_default_shared_archive_path() and ensures the path string is only generated once.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303548: Arguments::get_default_shared_archive_path() should cache the result for future use

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12963/head:pull/12963
$ git checkout pull/12963

Update a local copy of the PR:
$ git checkout pull/12963
$ git pull https://git.openjdk.org/jdk pull/12963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12963

View PR using the GUI difftool:
$ git pr show -t 12963

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12963.diff

[bridgekeeper]

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@matias9927 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b21ebe6e)

[calvinccheung]

LGTM

[openjdk]

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303548: Arguments::get_default_shared_archive_path() should cache the result for future use

Reviewed-by: ccheung, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• de9f3b6: 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL
• b9951dd: 8303820: Simplify type metadata
• 75d6306: 8303349: Simplify link format for generic types in index pages
• b1d89f3: 8294971: jdk.jlink jdk.tools.jimage.JImageTask is using ASM to verify classes
• 0f26d09: 8303822: gtestMain should give more helpful output
• e26cc52: 8303624: The java.lang.Thread.FieldHolder can be null for JNI attaching threads
• d06308c: 8302360: Atomic*.compareAndExchange Javadoc unclear
• 8b740b4: 8302779: HelidonAppTest.java fails with "assert(_cb == CodeCache::find_blob(pc())) failed: Must be the same" or SIGSEGV
• 562c8fc: 8303691: Fedora based devkit build should load more packages from archive location
• e930b63: 8303924: ProblemList serviceability/sa/UniqueVtableTest.java on Linux
• ... and 2 more: https://git.openjdk.org/jdk/compare/5726d31e56530bbe7dee61ae04b126e20cb3611d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@calvinccheung, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dholmes-ora]

LGTM2

Thanks

[matias9927]

Thank you @dholmes-ora and @calvinccheung!
/integrate

[openjdk]

@matias9927
Your change (at version b21ebe6) is now ready to be sponsored by a Committer.

[coleenp]

/sponsor

[openjdk]

Going to push as commit 548d552.
Since your change was applied there have been 16 commits pushed to the master branch:

• f2a36b4: 8302666: Replace CHM with VarHandle in ForeachOrderedTask
• a32ee5d: 8303949: gcc10 warning Linux ppc64le - note: the layout of aggregates containing vectors with 8-byte alignment has changed in GCC 5
• 01312a0: 8300821: UB: Applying non-zero offset to non-null pointer 0xfffffffffffffffe produced null pointer
• 6d30bbe: 8303001: Add test for re-entrant upcalls
• de9f3b6: 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL
• b9951dd: 8303820: Simplify type metadata
• 75d6306: 8303349: Simplify link format for generic types in index pages
• b1d89f3: 8294971: jdk.jlink jdk.tools.jimage.JImageTask is using ASM to verify classes
• 0f26d09: 8303822: gtestMain should give more helpful output
• e26cc52: 8303624: The java.lang.Thread.FieldHolder can be null for JNI attaching threads
• ... and 6 more: https://git.openjdk.org/jdk/compare/5726d31e56530bbe7dee61ae04b126e20cb3611d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp @matias9927 Pushed as commit 548d552.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.