8303930: Fix ConstantUtils.skipOverFieldSignature void case return value

[liach]

This typo doesn't allow creation of malformed ClassDesc or MethodTypeDesc, but it produces an erroneous exception on certain inputs. Running java.lang.constant.MethodTypeDesc.ofDescriptor("(IIIII[[[V)I") in Jshell 19.0.2 throws StringIndexOutOfBoundsException, and throws IllegalArgumentException in the Jshell for this patch.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303930: Fix ConstantUtils.skipOverFieldSignature void case return value

Reviewers

• Mandy Chung (@mlchung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/12964/head:pull/12964
$ git checkout pull/12964

Update a local copy of the PR:
$ git checkout pull/12964
$ git pull https://git.openjdk.org/jdk.git pull/12964/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12964

View PR using the GUI difftool:
$ git pr show -t 12964

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12964.diff

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (a3f892a6)
• 02: Full - Incremental (f53269ca)
• 01: Full - Incremental (d7b38bcf)
• 00: Full (075c6050)

[liach]

Could any engineer please review this patch fixing ConstantUtils.skipOverFieldSignature throwing StringIndexOutOfBoundsException on certain crafted inputs?

[mlchung]

Otherwise, looks good.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303930: Fix ConstantUtils.skipOverFieldSignature void case return value

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 124 new commits pushed to the master branch:

• 345669c: 8302738: IGV: refine 'Simplify graph' filter
• dea9db2: 8305055: IR check fails on some aarch64 platforms
• c8f3a97: 8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()
• 7fe5bd2: 8305174: disable dtrace for s390x builds
• 787832a: 8304988: unnecessary dash in @param gives double-dash in docs
• a144c71: 8305008: RISC-V: Factor out immediate checking functions from assembler_riscv.inline.hpp
• d815889: 8304993: bad sentence break in DateFormat
• 5f7b4b8: 8305111: Locale.lookupTag has typo in parameter
• 83cf28f: 8305142: Can't bootstrap ctw.jar
• 05cc02b: 8202110: (fs) Remove FileSystem support for resolving against a default directory (chdir configuration)
• ... and 114 more: https://git.openjdk.org/jdk/compare/0deb648985b018653ccdaf193dc13b3cf21c088a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[liach]

/integrate

[openjdk]

@liach
Your change (at version a3f892a) is now ready to be sponsored by a Committer.

[mlchung]

/sponsor

[openjdk]

Going to push as commit bdbf8fc.
Since your change was applied there have been 130 commits pushed to the master branch:

• 4a5d7ca: 8305227: [s390x] build broken after JDK-8231349
• dae1ab3: 8304844: JFR: Missing disk parameter in ActiveRecording event
• e012685: 8305066: [JVMCI] guarantee(ik->is_initialized()) failed: java/lang/Long$LongCache must be initialized
• fe42312: 8304820: Statically allocate ObjectSynchronizer mutexes
• 2f36eb0: 8305323: Update java/net/httpclient/ContentLengthHeaderTest.java to use new HttpTestServer factory methods
• 049b953: 8305223: IGV: mark osr compiled graphs with [OSR] in the name
• 345669c: 8302738: IGV: refine 'Simplify graph' filter
• dea9db2: 8305055: IR check fails on some aarch64 platforms
• c8f3a97: 8305171: PPC: Should use IMA::load_resolved_indy_entry() in TIG::generate_return_entry_for()
• 7fe5bd2: 8305174: disable dtrace for s390x builds
• ... and 120 more: https://git.openjdk.org/jdk/compare/0deb648985b018653ccdaf193dc13b3cf21c088a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mlchung @liach Pushed as commit bdbf8fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.