8303963: Replace various encodings of UINT/SIZE_MAX in gc code

[tschatzl]

Hi all,

please review this refactoring that replaces various casts in GC and more-or-less related to get all bits set in an uint/size_t with the available constants from cstdint.
The ones in ZGC files were skipped on request.

Testing: local compilation, gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303963: Replace various encodings of UINT/SIZE_MAX in gc code

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12973/head:pull/12973
$ git checkout pull/12973

Update a local copy of the PR:
$ git checkout pull/12973
$ git pull https://git.openjdk.org/jdk pull/12973/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12973

View PR using the GUI difftool:
$ git pr show -t 12973

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12973.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[tschatzl]

/label add hotspot-gc

[openjdk]

@tschatzl
The hotspot-gc label was successfully added.

[mlbridge]

Webrevs

• 00: Full (fce179b8)

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303963: Replace various encodings of UINT/SIZE_MAX in gc code

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• d7f4221: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode
• 94de0a7: 8302513: remove sun.awt.util.IdentityLinkedList
• bf16b5b: 8303937: Corrupted heap dumps due to missing retries for os::write()
• 6f54eda: 8299088: ClassLoader::defineClass2 throws OOME but JNI exception pending thrown by getUTF
• a3358b1: 8303853: Update ISO 3166 country codes table
• 206661d: 8281941: Change CDS warning messages to use Unified Logging
• 9dd7b87: 8303674: JFR: TypeLibrary class not thread safe
• c26e1d0: 8303495: Unused path parameter in ClassLoader::add_to_app_classpath_entries(JavaThread* current, char* path, ...)
• 548d552: 8303548: Arguments::get_default_shared_archive_path() should cache the result for future use
• f2a36b4: 8302666: Replace CHM with VarHandle in ForeachOrderedTask
• ... and 5 more: https://git.openjdk.org/jdk/compare/75d630621c86840eed9b29bf6e4c5e22e82369f0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kimbarrett]

Looks good.

[tschatzl]

Thanks @albertnetymk @kimbarrett for your reviews

/integrate

[openjdk]

Going to push as commit b575e54.
Since your change was applied there have been 25 commits pushed to the master branch:

• c183fce: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms
• 31e1e39: 8303646: [JVMCI] Add possibility to lookup ResolvedJavaType from jclass.
• 1148a65: 8303678: [JVMCI] Add possibility to convert object JavaConstant to jobject.
• d20bde2: 8294715: Add IR checks to the reduction vectorization tests
• c313e1a: 8303922: build-test-lib target is broken
• fbc76c2: 8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
• a06426a: 8274400: HotSpot Style Guide should permit use of alignof
• 98a7a60: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604
• 0a4d54f: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out
• 2116928: 8303900: Rename BitMap search functions
• ... and 15 more: https://git.openjdk.org/jdk/compare/75d630621c86840eed9b29bf6e4c5e22e82369f0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit b575e54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.