Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298469: Obsolete legacy parallel class loading workaround for non-parallel-capable class loaders #12974

Closed
wants to merge 2 commits into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Mar 10, 2023

This change removes the JVM code and option (default off) to synchronize class loading for non-parallel capable class loading. For more information see: https://bugs.openjdk.org/browse/JDK-8295673
and Release Note for the option in 20: https://bugs.openjdk.org/browse/JDK-8296446

Now Release Note for removal: https://bugs.openjdk.org/browse/JDK-8303967

Tested with tier1-7.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8304056 to be approved

Issues

  • JDK-8298469: Obsolete legacy parallel class loading workaround for non-parallel-capable class loaders
  • JDK-8304056: Obsolete legacy parallel class loading workaround for non-parallel-capable class loaders (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12974/head:pull/12974
$ git checkout pull/12974

Update a local copy of the PR:
$ git checkout pull/12974
$ git pull https://git.openjdk.org/jdk pull/12974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12974

View PR using the GUI difftool:
$ git pr show -t 12974

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12974.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2023

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 10, 2023
@openjdk
Copy link

openjdk bot commented Mar 10, 2023

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 10, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2023

Webrevs

@mlchung
Copy link
Member

mlchung commented Mar 10, 2023

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Mar 10, 2023
@openjdk
Copy link

openjdk bot commented Mar 10, 2023

@mlchung has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@coleenp please create a CSR request for issue JDK-8298469 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of queries below. Not all the changes are obvious.

Thanks.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing further from me. Looks good. Thanks!

src/hotspot/share/classfile/placeholders.cpp Show resolved Hide resolved
src/hotspot/share/runtime/objectMonitor.cpp Show resolved Hide resolved
@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Mar 16, 2023
@openjdk
Copy link

openjdk bot commented Mar 16, 2023

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298469: Obsolete legacy parallel class loading workaround for non-parallel-capable class loaders

Reviewed-by: dholmes, fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the master branch:

  • 02a4ee2: 8303921: serviceability/sa/UniqueVtableTest.java timed out
  • 4486f1b: 8304367: jlink --include-locales=* attempts to parse non .class resource files with classfile reader
  • 8d2ebf2: 8303697: ProcessTools doesn't print last line of process output
  • d5a1507: 8304314: StackWalkTest.java fails after CODETOOLS-7903373
  • 384a8b8: 8303069: Memory leak in CompilerOracle::parse_from_line
  • 6dd6c15: 8301684: Fix test code to not get finalizer deprecation warnings
  • cb4ae19: 8292059: Do not inline InstanceKlass::allocate_instance()
  • b2639e1: 8304164: jdk/classfile/CorpusTest.java still fails after JDK-8303910
  • 620564a: 8304130: Add runtime/StackGuardPages/TestStackGuardPagesNative.java to ProblemList.txt
  • 9d518c5: 8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp
  • ... and 106 more: https://git.openjdk.org/jdk/compare/68b5eef44f28ce603a8796545dfa4d3558659bdf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 16, 2023
@coleenp
Copy link
Contributor Author

coleenp commented Mar 17, 2023

Thanks David for the review and help clarifying the wording of the CSR and release note.

@coleenp
Copy link
Contributor Author

coleenp commented Mar 17, 2023

Thank you Fred.
/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2023

Going to push as commit 932be35.
Since your change was applied there have been 116 commits pushed to the master branch:

  • 02a4ee2: 8303921: serviceability/sa/UniqueVtableTest.java timed out
  • 4486f1b: 8304367: jlink --include-locales=* attempts to parse non .class resource files with classfile reader
  • 8d2ebf2: 8303697: ProcessTools doesn't print last line of process output
  • d5a1507: 8304314: StackWalkTest.java fails after CODETOOLS-7903373
  • 384a8b8: 8303069: Memory leak in CompilerOracle::parse_from_line
  • 6dd6c15: 8301684: Fix test code to not get finalizer deprecation warnings
  • cb4ae19: 8292059: Do not inline InstanceKlass::allocate_instance()
  • b2639e1: 8304164: jdk/classfile/CorpusTest.java still fails after JDK-8303910
  • 620564a: 8304130: Add runtime/StackGuardPages/TestStackGuardPagesNative.java to ProblemList.txt
  • 9d518c5: 8299375: [PPC64] GetStackTraceSuspendedStressTest tries to deoptimize frame with invalid fp
  • ... and 106 more: https://git.openjdk.org/jdk/compare/68b5eef44f28ce603a8796545dfa4d3558659bdf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2023
@openjdk openjdk bot closed this Mar 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2023
@openjdk
Copy link

openjdk bot commented Mar 17, 2023

@coleenp Pushed as commit 932be35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the no-double-lock branch March 17, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants