8303969: Limit printed failures within an object during G1 heap verification

[tschatzl]

Hi all,

please review this change to limit per-object liveness and remembered set error printing by G1MaxVerifyFailures too to avoid filling the log/disk when there is a large object that has many failures.

Testing: local compilation, local verification getting less error output on verification failure on humongous objects

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8303969: Limit printed failures within an object during G1 heap verification

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12977/head:pull/12977
$ git checkout pull/12977

Update a local copy of the PR:
$ git checkout pull/12977
$ git pull https://git.openjdk.org/jdk pull/12977/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12977

View PR using the GUI difftool:
$ git pr show -t 12977

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12977.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f8291eac)

[albertnetymk]

The new msg unnecessarily exposes some impl detail, IMO.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303969: Limit printed failures within an object during G1 heap verification

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 6d30bbe: 8303001: Add test for re-entrant upcalls
• de9f3b6: 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL
• b9951dd: 8303820: Simplify type metadata

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

The new msg unnecessarily exposes some impl detail, IMO.

Users/developers may be surprised when looking at the description (if they ever do) that it may print many more messages than expected in some cases, and it has no effect on other subsystem verification.

As it is a develop option that can be changed at a moment's notice I think it is fair to be exact about what it does.

[tschatzl]

Thanks @albertnetymk @walulyai for your reviews

/integrate

[openjdk]

Going to push as commit 3018b47.
Since your change was applied there have been 26 commits pushed to the master branch:

• b575e54: 8303963: Replace various encodings of UINT/SIZE_MAX in gc code
• c183fce: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms
• 31e1e39: 8303646: [JVMCI] Add possibility to lookup ResolvedJavaType from jclass.
• 1148a65: 8303678: [JVMCI] Add possibility to convert object JavaConstant to jobject.
• d20bde2: 8294715: Add IR checks to the reduction vectorization tests
• c313e1a: 8303922: build-test-lib target is broken
• fbc76c2: 8304017: ProblemList com/sun/jdi/InvokeHangTest.java on windows-x64 in vthread mode
• a06426a: 8274400: HotSpot Style Guide should permit use of alignof
• 98a7a60: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604
• 0a4d54f: 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java timed out
• ... and 16 more: https://git.openjdk.org/jdk/compare/75d630621c86840eed9b29bf6e4c5e22e82369f0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 3018b47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.