Skip to content

8303917: Update ISO 639 language codes table#12980

Closed
justin-curtis-lu wants to merge 6 commits intoopenjdk:masterfrom
justin-curtis-lu:JDK-8303917-ISO639-Update
Closed

8303917: Update ISO 639 language codes table#12980
justin-curtis-lu wants to merge 6 commits intoopenjdk:masterfrom
justin-curtis-lu:JDK-8303917-ISO639-Update

Conversation

@justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Mar 10, 2023

This PR modifies java.util.LocaleISOData.isoLanguageTable to include (name only) changes from up-to-date ISO 639 data.

In addition, this PR updates the ISO 639 data (generated in 1999) in Bug4175998Test.java. This includes modifying the generate_Tables() function, since the source data is now stored in a different format. The outdated raw data stored in the bottom of the file was removed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12980/head:pull/12980
$ git checkout pull/12980

Update a local copy of the PR:
$ git checkout pull/12980
$ git pull https://git.openjdk.org/jdk pull/12980/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12980

View PR using the GUI difftool:
$ git pr show -t 12980

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12980.diff

@justin-curtis-lu justin-curtis-lu marked this pull request as ready for review March 10, 2023 17:27
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 10, 2023
@openjdk
Copy link

openjdk bot commented Mar 10, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Mar 10, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2023

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

System.out.print("\""+iso639_1+"\",");
System.out.print("\""+iso639_2B+"\",");
System.out.print("\""+iso639_2T+"\"");
System.out.println("},");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be simplified like

System.out.printf("""
    {"%s","%s","%s"},
""", iso639_1, iso639_2B, iso639_2T);

@openjdk
Copy link

openjdk bot commented Mar 10, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303917: Update ISO 639 language codes table

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 172 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 10, 2023
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@justin-curtis-lu
Your change (at version a43f9f4) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented Mar 23, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 23, 2023

Going to push as commit dd23ee9.
Since your change was applied there have been 280 commits pushed to the master branch:

  • 6f67abd: 8304557: java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java times out
  • 568dd57: 8304716: Clean up G1Policy::calc_max_old_cset_length()
  • af0504e: 8304691: Remove jlink --post-process-path option
  • 3859faf: 8231349: Move intrinsic stubs generation to compiler runtime initialization code
  • f37674a: 8304711: Combine G1 root region abort and wait into a single method
  • 7f9e691: 8304712: Only pass total number of regions into G1Policy::calc_min_old_cset_length
  • 51035a7: 8294137: Review running times of java.math tests
  • 46cca1a: 4842457: (bf spec) Clarify meaning of "(optional operation)"
  • 6fa25cc: 8184444: The compiler error "variable not initialized in the default constructor" is not apt in case of static final variables
  • 4b8f7db: 8027682: javac wrongly accepts semicolons in package and import decls
  • ... and 270 more: https://git.openjdk.org/jdk/compare/f3abc4063de658418283aee1f552c4b4976e5211...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 23, 2023
@openjdk openjdk bot closed this Mar 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 23, 2023
@openjdk
Copy link

openjdk bot commented Mar 23, 2023

@naotoj @justin-curtis-lu Pushed as commit dd23ee9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants