8303917: Update ISO 639 language codes table#12980
8303917: Update ISO 639 language codes table#12980justin-curtis-lu wants to merge 6 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
|
@justin-curtis-lu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
| System.out.print("\""+iso639_1+"\","); | ||
| System.out.print("\""+iso639_2B+"\","); | ||
| System.out.print("\""+iso639_2T+"\""); | ||
| System.out.println("},"); |
There was a problem hiding this comment.
Could be simplified like
System.out.printf("""
{"%s","%s","%s"},
""", iso639_1, iso639_2B, iso639_2T);
|
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 172 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@justin-curtis-lu |
|
/sponsor |
|
Going to push as commit dd23ee9.
Your commit was automatically rebased without conflicts. |
|
@naotoj @justin-curtis-lu Pushed as commit dd23ee9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR modifies
java.util.LocaleISOData.isoLanguageTableto include (name only) changes from up-to-date ISO 639 data.In addition, this PR updates the ISO 639 data (generated in 1999) in
Bug4175998Test.java. This includes modifying thegenerate_Tables()function, since the source data is now stored in a different format. The outdated raw data stored in the bottom of the file was removed.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12980/head:pull/12980$ git checkout pull/12980Update a local copy of the PR:
$ git checkout pull/12980$ git pull https://git.openjdk.org/jdk pull/12980/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12980View PR using the GUI difftool:
$ git pr show -t 12980Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12980.diff