Skip to content

JDK-8303973: Library detection in runtime/ErrorHandling/TestDwarf.java fails on ppc64le RHEL8.5 for libpthread-2.28.so #12998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Mar 13, 2023

The test fails with

[dwarf] ##### Find filename and line number for offset 0x000096a8 in library /lib64/glibc-hwcaps/power9/libpthread-2.28.so #####
[dwarf] Failed to load DWARF file for library /lib64/glibc-hwcaps/power9/libpthread-2.28.so or find DWARF sections directly inside it.

and in stderr

java.lang.RuntimeException: Must find library in "C [libpthread-2.28.so+0x96a8] start_thread+0xf8": expected true, was false

Looks like the '-' in the lib-name libpthread-2.28.so is currently not allowed in the pattern of the test. This is similar to JDK-8293201 .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303973: Library detection in runtime/ErrorHandling/TestDwarf.java fails on ppc64le RHEL8.5 for libpthread-2.28.so

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12998/head:pull/12998
$ git checkout pull/12998

Update a local copy of the PR:
$ git checkout pull/12998
$ git pull https://git.openjdk.org/jdk pull/12998/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12998

View PR using the GUI difftool:
$ git pr show -t 12998

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12998.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 13, 2023
@openjdk
Copy link

openjdk bot commented Mar 13, 2023

@MBaesken The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 13, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 13, 2023

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial!

@openjdk
Copy link

openjdk bot commented Mar 13, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303973: Library detection in runtime/ErrorHandling/TestDwarf.java fails on ppc64le RHEL8.5 for libpthread-2.28.so

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 4cf4c59: 8303824: Parallel: Use more strict card table API
  • 8e41bf2: 8303238: Create generalizations for existing LShift ideal transforms
  • 805a4e6: 8303883: Confusing parameter name in G1UpdateRemSetTrackingBeforeRebuild::distribute_marked_bytes
  • 25e7ac2: 8294966: Convert jdk.jartool/sun.tools.jar.FingerPrint to use the ClassFile API to parse JAR entries
  • 3018b47: 8303969: Limit printed failures within an object during G1 heap verification
  • b575e54: 8303963: Replace various encodings of UINT/SIZE_MAX in gc code
  • c183fce: 8300926: Several startup regressions ~6-70% in 21-b6 all platforms
  • 31e1e39: 8303646: [JVMCI] Add possibility to lookup ResolvedJavaType from jclass.
  • 1148a65: 8303678: [JVMCI] Add possibility to convert object JavaConstant to jobject.
  • d20bde2: 8294715: Add IR checks to the reduction vectorization tests
  • ... and 18 more: https://git.openjdk.org/jdk/compare/6d30bbe62c10af0f2c80cb1eaac3d171fb7bffcb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 13, 2023
@MBaesken
Copy link
Member Author

Looks good and trivial!

Hi Christian, thanks for the review ! One question - maybe you have an opinion on that, should we use backslashes on the '-' , because it could be mistaken with a pattern-range ?

@chhagedorn
Copy link
Member

I don't have a strong opinion there - I guess both is acceptable.

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2023

Going to push as commit b6d70f2.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 2bb990e: 8301244: Tidy up compiler specific warnings files
  • c073ef2: 8303482: Update LCMS to 2.15
  • 49181b8: 8303955: RISC-V: Factor out the tmp parameter from copy_memory and copy_memory_v
  • 7bbc5e0: 8300517: Refactor VisibleMemberTable (method members)
  • a8f662e: 8303908: Add missing check in VTMS_transition_disable_for_all() for suspend mode
  • 5685107: 8302491: NoClassDefFoundError omits the original cause of an error
  • 671a452: 8303606: Memory leaks in Arguments::parse_each_vm_init_arg
  • a95bc7a: 8294974: Convert jdk.jshell/jdk.jshell.execution.LocalExecutionControl to use the Classfile API to instrument classes
  • f835aaa: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"
  • 466ffeb: 8303965: java.net.http.HttpClient should reset the stream if response headers contain malformed header fields
  • ... and 29 more: https://git.openjdk.org/jdk/compare/6d30bbe62c10af0f2c80cb1eaac3d171fb7bffcb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2023
@openjdk openjdk bot closed this Mar 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@MBaesken Pushed as commit b6d70f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants