-
Notifications
You must be signed in to change notification settings - Fork 5.8k
JDK-8303973: Library detection in runtime/ErrorHandling/TestDwarf.java fails on ppc64le RHEL8.5 for libpthread-2.28.so #12998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial!
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Hi Christian, thanks for the review ! One question - maybe you have an opinion on that, should we use backslashes on the '-' , because it could be mistaken with a pattern-range ? |
I don't have a strong opinion there - I guess both is acceptable. |
/integrate |
Going to push as commit b6d70f2.
Your commit was automatically rebased without conflicts. |
The test fails with
[dwarf] ##### Find filename and line number for offset 0x000096a8 in library /lib64/glibc-hwcaps/power9/libpthread-2.28.so #####
[dwarf] Failed to load DWARF file for library /lib64/glibc-hwcaps/power9/libpthread-2.28.so or find DWARF sections directly inside it.
and in stderr
java.lang.RuntimeException: Must find library in "C [libpthread-2.28.so+0x96a8] start_thread+0xf8": expected true, was false
Looks like the '-' in the lib-name libpthread-2.28.so is currently not allowed in the pattern of the test. This is similar to JDK-8293201 .
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12998/head:pull/12998
$ git checkout pull/12998
Update a local copy of the PR:
$ git checkout pull/12998
$ git pull https://git.openjdk.org/jdk pull/12998/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12998
View PR using the GUI difftool:
$ git pr show -t 12998
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12998.diff