8304059: Use InstanceKlass in dependencies

[coleenp]

Please review this small change to eliminate InstanceKlass::cast() calls for things that should be already InstanceKlass.
Tested with tier1-4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304059: Use InstanceKlass in dependencies

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13005/head:pull/13005
$ git checkout pull/13005

Update a local copy of the PR:
$ git checkout pull/13005
$ git pull https://git.openjdk.org/jdk pull/13005/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13005

View PR using the GUI difftool:
$ git pr show -t 13005

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13005.diff

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7bf34060)

[iwanowww]

Looks good. Thanks for cleaning it up!

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304059: Use InstanceKlass in dependencies

Reviewed-by: vlivanov, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 43eca1d: 8303910: jdk/classfile/CorpusTest.java failed 1 of 6754 tests
• b6d70f2: 8303973: Library detection in runtime/ErrorHandling/TestDwarf.java fails on ppc64le RHEL8.5 for libpthread-2.28.so
• 2bb990e: 8301244: Tidy up compiler specific warnings files
• c073ef2: 8303482: Update LCMS to 2.15
• 49181b8: 8303955: RISC-V: Factor out the tmp parameter from copy_memory and copy_memory_v
• 7bbc5e0: 8300517: Refactor VisibleMemberTable (method members)
• a8f662e: 8303908: Add missing check in VTMS_transition_disable_for_all() for suspend mode
• 5685107: 8302491: NoClassDefFoundError omits the original cause of an error
• 671a452: 8303606: Memory leaks in Arguments::parse_each_vm_init_arg
• a95bc7a: 8294974: Convert jdk.jshell/jdk.jshell.execution.LocalExecutionControl to use the Classfile API to instrument classes
• ... and 1 more: https://git.openjdk.org/jdk/compare/466ffebcae1ee5817a83fdbc33f5ec3bd6de7e60...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Thanks Vladimir.

[TobiHartmann]

Looks good to me too.

[coleenp]

Thank you Tobias.
/integrate

[openjdk]

Going to push as commit 55aa122.
Since your change was applied there have been 14 commits pushed to the master branch:

• ec1eb00: 8303415: Add VM_Version::is_intrinsic_supported(id)
• 31680b2: 8303410: Remove ContentSigner APIs and jarsigner -altsigner and -altsignerpath options
• 0cc0f06: 8304015: G1: Metaspace-induced GCs should not trigger maximal compaction
• 43eca1d: 8303910: jdk/classfile/CorpusTest.java failed 1 of 6754 tests
• b6d70f2: 8303973: Library detection in runtime/ErrorHandling/TestDwarf.java fails on ppc64le RHEL8.5 for libpthread-2.28.so
• 2bb990e: 8301244: Tidy up compiler specific warnings files
• c073ef2: 8303482: Update LCMS to 2.15
• 49181b8: 8303955: RISC-V: Factor out the tmp parameter from copy_memory and copy_memory_v
• 7bbc5e0: 8300517: Refactor VisibleMemberTable (method members)
• a8f662e: 8303908: Add missing check in VTMS_transition_disable_for_all() for suspend mode
• ... and 4 more: https://git.openjdk.org/jdk/compare/466ffebcae1ee5817a83fdbc33f5ec3bd6de7e60...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 55aa122.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.