Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303705: Field sleeper.started should be volatile JdbLockTestTarg.java #13010

Closed
wants to merge 1 commit into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Mar 14, 2023

Field has been made volatile.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303705: Field sleeper.started should be volatile JdbLockTestTarg.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13010/head:pull/13010
$ git checkout pull/13010

Update a local copy of the PR:
$ git checkout pull/13010
$ git pull https://git.openjdk.org/jdk pull/13010/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13010

View PR using the GUI difftool:
$ git pr show -t 13010

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13010.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2023

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@lmesnik The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Mar 14, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine and trivial.

Thanks

@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303705: Field sleeper.started should be volatile JdbLockTestTarg.java

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • c073ef2: 8303482: Update LCMS to 2.15
  • 49181b8: 8303955: RISC-V: Factor out the tmp parameter from copy_memory and copy_memory_v

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2023
@lmesnik
Copy link
Member Author

lmesnik commented Mar 14, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2023

Going to push as commit cd41c69.
Since your change was applied there have been 21 commits pushed to the master branch:

  • f5c8b68: 8301998: Update HarfBuzz to 7.0.1
  • 617c15f: 8304172: ProblemList serviceability/sa/UniqueVtableTest.java
  • f81e1de: 8303882: Refactor some iterators in jdk.compiler
  • 45809fd: 8295884: Implement IDE support for Eclipse
  • baf11e7: 8303814: getLastErrorString should avoid charset conversions
  • 830fd41: 8302795: Shared archive failed on old version class with jsr bytecode
  • 4e631fa: 8298966: Deprecate JMX Subject Delegation and the method JMXConnector.getMBeanServerConnection(Subject) for removal.
  • 10f1674: 8303809: Dispose context in SPNEGO NegotiatorImpl
  • 9f9ab02: 8303895: Simplify and clean up LinkFactory code
  • a00f5d2: 8303861: Error handling step timeouts should never be blocked by OnError and others
  • ... and 11 more: https://git.openjdk.org/jdk/compare/7bbc5e0efbcbf97e8c1d4e889bd06c33c5f4eaa5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2023
@openjdk openjdk bot closed this Mar 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@lmesnik Pushed as commit cd41c69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants