-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8270865: Print process ID with -Xlog:os #13015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into |
@jdksjolen The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. I could quibble about how to word this but it doesn't really matter. :)
Thanks
@jdksjolen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 72 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks :). /integrate |
Going to push as commit e3777b0.
Your commit was automatically rebased without conflicts. |
@jdksjolen Pushed as commit e3777b0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Adds logging of the process ID fairly early in the process (right after
HOTSPOT_VM_INIT_END();
) as a quality of life improvement.Citing the ticket:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13015/head:pull/13015
$ git checkout pull/13015
Update a local copy of the PR:
$ git checkout pull/13015
$ git pull https://git.openjdk.org/jdk pull/13015/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13015
View PR using the GUI difftool:
$ git pr show -t 13015
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13015.diff