Skip to content

8270865: Print process ID with -Xlog:os #13015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jdksjolen
Copy link
Contributor

@jdksjolen jdksjolen commented Mar 14, 2023

Adds logging of the process ID fairly early in the process (right after HOTSPOT_VM_INIT_END();) as a quality of life improvement.

Citing the ticket:

It's useful to add the PID into a log file. For example, we can use it to find the corresponding hs_err_.log


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13015/head:pull/13015
$ git checkout pull/13015

Update a local copy of the PR:
$ git checkout pull/13015
$ git pull https://git.openjdk.org/jdk pull/13015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13015

View PR using the GUI difftool:
$ git pr show -t 13015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13015.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2023

👋 Welcome back jsjolen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 14, 2023
@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@jdksjolen The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 14, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I could quibble about how to word this but it doesn't really matter. :)

Thanks

@openjdk
Copy link

openjdk bot commented Mar 14, 2023

@jdksjolen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270865: Print process ID with -Xlog:os

Reviewed-by: dholmes, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2023
Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jdksjolen
Copy link
Contributor Author

Thanks :).

/integrate

@openjdk
Copy link

openjdk bot commented Mar 15, 2023

Going to push as commit e3777b0.
Since your change was applied there have been 74 commits pushed to the master branch:

  • 349139b: 8304030: Configure call fails on AIX when using --with-gtest option.
  • 714b5f0: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class
  • 065d3e0: 8304171: Fix layout of JCov instrumented bundle on Mac OS
  • cd41c69: 8303705: Field sleeper.started should be volatile JdbLockTestTarg.java
  • f5c8b68: 8301998: Update HarfBuzz to 7.0.1
  • 617c15f: 8304172: ProblemList serviceability/sa/UniqueVtableTest.java
  • f81e1de: 8303882: Refactor some iterators in jdk.compiler
  • 45809fd: 8295884: Implement IDE support for Eclipse
  • baf11e7: 8303814: getLastErrorString should avoid charset conversions
  • 830fd41: 8302795: Shared archive failed on old version class with jsr bytecode
  • ... and 64 more: https://git.openjdk.org/jdk/compare/5726d31e56530bbe7dee61ae04b126e20cb3611d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 15, 2023
@openjdk openjdk bot closed this Mar 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2023
@openjdk
Copy link

openjdk bot commented Mar 15, 2023

@jdksjolen Pushed as commit e3777b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants