8304136: Match allocation and free in sspi.cpp

[wangweij]

After this change, gss_buffer_t always uses malloc and free. All others use new and delete. It also initializes several SecBuffer to zeroes so it's safe to check for null when trying to free them.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304136: Match allocation and free in sspi.cpp

Reviewers

• Daniel Jeliński (@djelinski - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13018/head:pull/13018
$ git checkout pull/13018

Update a local copy of the PR:
$ git checkout pull/13018
$ git pull https://git.openjdk.org/jdk.git pull/13018/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13018

View PR using the GUI difftool:
$ git pr show -t 13018

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13018.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (519c6139)

[djelinski]

LGTM. Thanks!

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304136: Match allocation and free in sspi.cpp

Reviewed-by: djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 124 new commits pushed to the master branch:

• 6fa25cc: 8184444: The compiler error "variable not initialized in the default constructor" is not apt in case of static final variables
• 4b8f7db: 8027682: javac wrongly accepts semicolons in package and import decls
• c00d088: 8043179: Lambda expression can mutate final field
• 147f347: 8219083: java/net/MulticastSocket/SetGetNetworkInterfaceTest.java failed in same binary run on windows x64
• bf917ba: 8304687: Move add_to_hierarchy
• 63d4afb: 8304671: javac regression: Compilation with --release 8 fails on underscore in enum identifiers
• e2cfcfb: 6817009: Action.SELECTED_KEY not toggled when using key binding
• af4d560: 8303951: Add asserts before record_method_not_compilable where possible
• c433862: 6245410: javax.swing.text.html.CSS.Attribute: BACKGROUND_POSITION is not w3c spec compliant
• 91f407d: 8029301: Confusing error message for array creation method reference
• ... and 114 more: https://git.openjdk.org/jdk/compare/5685107579f0f00b5eae881311315cec34c1ddcb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

Congratulations to @djelinski for being promoted to an OpenJDK Reviewer!
/integrate

[openjdk]

Going to push as commit 765a942.
Since your change was applied there have been 145 commits pushed to the master branch:

• 3f59b75: 8304898: Fix Copyright Headers for JLink Source Files
• 501b606: 8298725: Add BitMap support for reverse iteration
• 9764948: 8273986: JEditorPane HTML Demo - Accessibility issues
• 5727610: 8304353: Add lib-test tier1 testing in GHA
• d8ba227: 8304069: ClassFileParser has ad-hoc hashtables
• 9a8a60f: 8304833: (fc) Remove dead code in sun.nio.ch.FileChannelImpl::implCloseChannel
• f96aee7: 8291154: Create a non static nested class without enclosing class throws VerifyError
• 4ec720d: 8297977: vmTestbase/nsk/stress/except/except012.java fails with unexpected Exception
• 13dd19a: 8304802: After JDK-8297639 the flag G1UsePreventiveGC needs to be added to the obsoletion table
• d61de14: 8303508: Vector.lane() gets wrong value on x86
• ... and 135 more: https://git.openjdk.org/jdk/compare/5685107579f0f00b5eae881311315cec34c1ddcb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit 765a942.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.