8304161: Add TypeKind.from to derive from TypeDescriptor.OfField

[liach]

Such an API allows creating TypeKind from both Class and ClassDesc than having to call descriptorString() explicitly at every use site.

See https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000240.html for context.

Upgraded usages of fromDescriptor to from in applicable use sites in Classfile API and its tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304161: Add TypeKind.from to derive from TypeDescriptor.OfField

Reviewers

• Jorn Vernee (@JornVernee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13024/head:pull/13024
$ git checkout pull/13024

Update a local copy of the PR:
$ git checkout pull/13024
$ git pull https://git.openjdk.org/jdk pull/13024/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13024

View PR using the GUI difftool:
$ git pr show -t 13024

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13024.diff

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6f2aacb5)

[JornVernee]

LGTM. I think @briangoetz might want to weigh in on this as well.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304161: Add TypeKind.from to derive from TypeDescriptor.OfField

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 2b81fae: 8303022: "assert(allocates2(pc)) failed: not in CodeBuffer memory" When linking downcall handle
• be08a25: 8304264: Debug messages always show up for NativeGSS
• 1ae69e3: 8304287: Problemlist java/net/SocketOption/OptionsTest.java
• 116627d: 8304267: JDK-8303415 missed change in Zero Interpreter
• 824a5e4: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates
• 7ad48ea: 8300317: vmTestbase/nsk/stress/strace/strace* tests fail with "ERROR: wrong lengths of stack traces"
• 35a2969: 8302659: Modernize Windows native code for NetworkInterface
• 01e6920: 8298935: fix independence bug in create_pack logic in SuperWord::find_adjacent_refs
• 3d77e21: 8301308: Remove version conditionalization for gcc/clang PRAGMA_DIAG_PUSH/POP
• e3777b0: 8270865: Print process ID with -Xlog:os
• ... and 11 more: https://git.openjdk.org/jdk/compare/10f16746254ce62031f40ffb0f49f22e81cbe631...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JornVernee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[briangoetz]

+1

[liach]

/integrate

[openjdk]

@liach
Your change (at version 6f2aacb) is now ready to be sponsored by a Committer.

[JornVernee]

/sponsor

[openjdk]

Going to push as commit 7dbab81.
Since your change was applied there have been 27 commits pushed to the master branch:

• d4eb395: 8303684: Lift upcall sharing mechanism to AbstractLinker (mainline)
• dfc7214: 8304283: Modernize the switch statements in jdk.internal.foreign
• 7277bb1: 8293324: ciField.hpp has two methods to return field's offset
• b7945bc: 8303154: Investigate and improve instruction cache flushing during compilation
• eefbaa2: 8283400: [macos] a11y : Screen magnifier does not reflect JRadioButton value change
• 42dd907: 8302906: AArch64: Add SVE backend support for vector unsigned comparison
• 2b81fae: 8303022: "assert(allocates2(pc)) failed: not in CodeBuffer memory" When linking downcall handle
• be08a25: 8304264: Debug messages always show up for NativeGSS
• 1ae69e3: 8304287: Problemlist java/net/SocketOption/OptionsTest.java
• 116627d: 8304267: JDK-8303415 missed change in Zero Interpreter
• ... and 17 more: https://git.openjdk.org/jdk/compare/10f16746254ce62031f40ffb0f49f22e81cbe631...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JornVernee @liach Pushed as commit 7dbab81.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.