8304264: Debug messages always show up for NativeGSS

[wangweij]

Only call debug() when DEBUG is set.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304264: Debug messages always show up for NativeGSS

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13043/head:pull/13043
$ git checkout pull/13043

Update a local copy of the PR:
$ git checkout pull/13043
$ git pull https://git.openjdk.org/jdk pull/13043/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13043

View PR using the GUI difftool:
$ git pr show -t 13043

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13043.diff

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5bf2e179)

[seanjmullan]

Is this debug property documented anywhere? If not, perhaps we should add it to the Troubleshooting guide.

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304264: Debug messages always show up for NativeGSS

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 01e6920: 8298935: fix independence bug in create_pack logic in SuperWord::find_adjacent_refs
• 3d77e21: 8301308: Remove version conditionalization for gcc/clang PRAGMA_DIAG_PUSH/POP
• e3777b0: 8270865: Print process ID with -Xlog:os
• 349139b: 8304030: Configure call fails on AIX when using --with-gtest option.
• 714b5f0: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class
• 065d3e0: 8304171: Fix layout of JCov instrumented bundle on Mac OS
• cd41c69: 8303705: Field sleeper.started should be volatile JdbLockTestTarg.java
• f5c8b68: 8301998: Update HarfBuzz to 7.0.1
• 617c15f: 8304172: ProblemList serviceability/sa/UniqueVtableTest.java
• f81e1de: 8303882: Refactor some iterators in jdk.compiler
• ... and 20 more: https://git.openjdk.org/jdk/compare/5685107579f0f00b5eae881311315cec34c1ddcb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[wangweij]

Is this debug property documented anywhere? If not, perhaps we should add it to the Troubleshooting guide.

We can add it to the "Accessing Native GSS-API" page. There is an existing "Troubleshooting" but it's inside the part about using JGSS with JAAS. Native GSS should not be used with JAAS.

[wangweij]

/integrate

[openjdk]

Going to push as commit be08a25.
Since your change was applied there have been 35 commits pushed to the master branch:

• 1ae69e3: 8304287: Problemlist java/net/SocketOption/OptionsTest.java
• 116627d: 8304267: JDK-8303415 missed change in Zero Interpreter
• 824a5e4: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates
• 7ad48ea: 8300317: vmTestbase/nsk/stress/strace/strace* tests fail with "ERROR: wrong lengths of stack traces"
• 35a2969: 8302659: Modernize Windows native code for NetworkInterface
• 01e6920: 8298935: fix independence bug in create_pack logic in SuperWord::find_adjacent_refs
• 3d77e21: 8301308: Remove version conditionalization for gcc/clang PRAGMA_DIAG_PUSH/POP
• e3777b0: 8270865: Print process ID with -Xlog:os
• 349139b: 8304030: Configure call fails on AIX when using --with-gtest option.
• 714b5f0: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class
• ... and 25 more: https://git.openjdk.org/jdk/compare/5685107579f0f00b5eae881311315cec34c1ddcb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit be08a25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.