-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8304242: CPUInfoTest fails because "serialize" CPU feature is not known #13062
Conversation
👋 Welcome back kosta777! A progress list of the required criteria for merging this PR into |
@kosta777 To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add hotspot-compiler |
@kosta777 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goos and trivial.
@kosta777 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @sviswa7, @TobiHartmann) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 36995c5.
Your commit was automatically rebased without conflicts. |
@TobiHartmann @kosta777 Pushed as commit 36995c5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This test fails on modern x86_64 hardware with "serialize" feature (eg. Intel Gen 12 and higher).
Support for this feature was added by JDK-8264543 but the test wasn't updated.
I have updated the test to recognize "serialize" as a supported CPU feature.
Tested on 13th Gen Intel(R) Core(TM) i7-13700K by running this new version of the test.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13062/head:pull/13062
$ git checkout pull/13062
Update a local copy of the PR:
$ git checkout pull/13062
$ git pull https://git.openjdk.org/jdk pull/13062/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13062
View PR using the GUI difftool:
$ git pr show -t 13062
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13062.diff