8304376: Rename t1/t2 classes in com/sun/jdi/CLETest.java to avoid class duplication error in IDE

[lmesnik]

The com/sun/jdi tests are located in the on package, and classes with same name cause 'class duplication error' when this directory is opened as source code in IDE.

The simplest fix to avoid this is just to rename class.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304376: Rename t1/t2 classes in com/sun/jdi/CLETest.java to avoid class duplication error in IDE

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13069/head:pull/13069
$ git checkout pull/13069

Update a local copy of the PR:
$ git checkout pull/13069
$ git pull https://git.openjdk.org/jdk.git pull/13069/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13069

View PR using the GUI difftool:
$ git pr show -t 13069

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13069.diff

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (6f455341)
• 00: Full (9c6e8b89)

[sspitsyn]

The fix looks good in general - approved.
Nit: But why don't use longer/better class names?

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304376: Rename t1/t2 classes in com/sun/jdi/CLETest.java to avoid class duplication error in IDE

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• f593a6b: 8303018: Unicode Emoji Properties
• bc0ed73: 8304303: implement VirtualThread class notifyJvmti methods as C2 intrinsics
• 2d0d057: 8304016: Add BitMap find_last suite of functions
• 42723dc: 8304420: Regression ~11% with Javac-Generates on all platforms in b14
• 19f2edd: 8304541: Modules THROW_MSG_ should return nullptr instead of JNI_FALSE
• 622f239: 8304163: Move jdk.internal.module.ModuleInfoWriter to the test library
• 4c8c993: 8304364: [AIX] Build erroneously determines build disk is non-local when using GNU-utils df on AIX
• 4ed7350: 8304393: Provide method to iterate over regions of humongous object in G1
• eb73fa8: 8301715: CDS should be disabled in exploded JDK
• 80e9797: 8304433: cleanup sentence breaker code in DocTreeMaker
• ... and 28 more: https://git.openjdk.org/jdk/compare/8eed7dea7b92dd98b74277e8521100f7f807eabb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

Nit: But why don't use longer/better class names?

You also might want to make it start with an uppercase letter.

[lmesnik]

Not sure there is any meaningful name for these classes. So I updated it to CLEClass1/2 so it uses CamelCase notation and has test name as prefix to be unique.

[sspitsyn]

Not sure there is any meaningful name for these classes. So I updated it to CLEClass1/2 so it uses CamelCase notation and has test name as prefix to be unique.

What does CLE stand for?

[lmesnik]

It is a just prefix for this test. It is named CLETest, where CLE is co-located event. I'm fine to change it to any unique enough name. However I didn't find any.

[sspitsyn]

Okay, thanks.

[lmesnik]

/integrate

[openjdk]

Going to push as commit e73411a.
Since your change was applied there have been 62 commits pushed to the master branch:

• a2d8f63: 8288730: Add type parameter to Lookup::accessClass and Lookup::ensureInitialized
• 3777455: 8302191: Performance degradation for float/double modulo on Linux
• 760c012: 8304683: Memory leak in WB_IsMethodCompatible
• 75168ea: 8304134: jib bootstrapper fails to quote filename when checking download filetype
• 4154a98: 8301498: Replace NULL with nullptr in cpu/x86
• ddf1e34: 8304089: Convert TraceDependencies to UL
• 358c61b: 8294972: Convert jdk.jlink internal plugins to use the Classfile API
• c74507e: 8304657: G1: Rename set_state_empty to set_state_untracked
• ca94287: 8304144: G1: Remove unnecessary is_survivor check in G1ClearCardTableTask
• eda0065: 8304286: java/net/SocketOption/OptionsTest.java failing after JDK-8302659
• ... and 52 more: https://git.openjdk.org/jdk/compare/8eed7dea7b92dd98b74277e8521100f7f807eabb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit e73411a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.