8304393: Provide method to iterate over regions of humongous object in G1

[tschatzl]

Hi all,

please review this refactoring that introduces a method to iterate over all regions of a humongous object and apply a function to it to decrease the five times code duplication.

Testing: gha

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304393: Provide method to iterate over regions of humongous object in G1

Reviewers

• Ivan Walulya (@walulyai - Reviewer) ⚠️ Review applies to f3df2340
• Albert Mingkun Yang (@albertnetymk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13080/head:pull/13080
$ git checkout pull/13080

Update a local copy of the PR:
$ git checkout pull/13080
$ git pull https://git.openjdk.org/jdk pull/13080/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13080

View PR using the GUI difftool:
$ git pr show -t 13080

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13080.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (bd89cbc9)
• 02: Full - Incremental (0ffe355e)
• 01: Full - Incremental (f3df2340)
• 00: Full (104871b8)

[walulyai]

Lgtm!

Minor nit:

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304393: Provide method to iterate over regions of humongous object in G1

Reviewed-by: iwalulya, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 652bda0: 8304411: Remove unused CardTable::clear
• 4505670: 8304174: Remove delays from httpserver tests
• c09f83e: 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1
• e339e18: 7016187: javac -h could generate conflict .h for inner class and class name with '_'
• 033c0b1: 8304437: ProblemList com/sun/jdi/ThreadMemoryLeadTest.java with ZGC
• 7503ecc: 8304138: [JVMCI] Test FailedSpeculation existence before appending.
• f8482c2: 8297638: Memory leak in case of many started-dead threads
• c56f011: 8298995: tools/jpackage/share/AddLauncherTest.java#id1 failed "AddLauncherTest.test; checks=53"
• 254288a: 8014021: TreeMaker.Params behaves inconsistently when the owning method has the same number of parameters as the number of parameter types requested
• 8f5bb53: 8015831: Add lint check for calling overridable methods from a constructor
• ... and 19 more: https://git.openjdk.org/jdk/compare/2f23c80e0de44815d26a7d541701e16c9c1d32bc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

Thanks @walulyai @albertnetymk for your reviews

/integrate

[openjdk]

Going to push as commit 4ed7350.
Since your change was applied there have been 33 commits pushed to the master branch:

• eb73fa8: 8301715: CDS should be disabled in exploded JDK
• 80e9797: 8304433: cleanup sentence breaker code in DocTreeMaker
• c396f1e: 8304443: bootcycle builds fail after JDK-8015831
• ded6a81: 8303742: CompletableFuture.orTimeout leaks if the future completes exceptionally
• 652bda0: 8304411: Remove unused CardTable::clear
• 4505670: 8304174: Remove delays from httpserver tests
• c09f83e: 8304293: RISC-V: JDK-8276799 missed atomic intrinsic support for C1
• e339e18: 7016187: javac -h could generate conflict .h for inner class and class name with '_'
• 033c0b1: 8304437: ProblemList com/sun/jdi/ThreadMemoryLeadTest.java with ZGC
• 7503ecc: 8304138: [JVMCI] Test FailedSpeculation existence before appending.
• ... and 23 more: https://git.openjdk.org/jdk/compare/2f23c80e0de44815d26a7d541701e16c9c1d32bc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 4ed7350.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.