Skip to content

8304437: ProblemList com/sun/jdi/ThreadMemoryLeadTest.java with ZGC #13087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Mar 18, 2023

This new test is failing with ZGC, I believe on every run. Needs to be problem listed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8304437: ProblemList com/sun/jdi/ThreadMemoryLeadTest.java with ZGC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/13087/head:pull/13087
$ git checkout pull/13087

Update a local copy of the PR:
$ git checkout pull/13087
$ git pull https://git.openjdk.org/jdk pull/13087/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13087

View PR using the GUI difftool:
$ git pr show -t 13087

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13087.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2023

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8304437 8304437: ProblemList com/sun/jdi/ThreadMemoryLeadTest.java with ZGC Mar 18, 2023
@plummercj
Copy link
Contributor Author

/label serviceability

@openjdk openjdk bot added rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org labels Mar 18, 2023
@openjdk
Copy link

openjdk bot commented Mar 18, 2023

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Mar 18, 2023

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem listed entry looks fine to me.

@openjdk
Copy link

openjdk bot commented Mar 18, 2023

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304437: ProblemList com/sun/jdi/ThreadMemoryLeadTest.java with ZGC

Reviewed-by: jpai, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7503ecc: 8304138: [JVMCI] Test FailedSpeculation existence before appending.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 18, 2023
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@plummercj
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 18, 2023

Going to push as commit 033c0b1.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7503ecc: 8304138: [JVMCI] Test FailedSpeculation existence before appending.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 18, 2023
@openjdk openjdk bot closed this Mar 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2023
@openjdk
Copy link

openjdk bot commented Mar 18, 2023

@plummercj Pushed as commit 033c0b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants