8253031: git jcheck complains about invalid tags in jdk repo after fix for JDK-8252844

[kevinrushforth]

In the fix for JDK-8252844 the tags entry in .jcheck/conf was copied from the Skara Java code. The \ chars were escaped as \\ in the Java String so that it would contain \. This additional level of escape is not needed in the .jcheck/conf file, and causes the regex to not be as intended. The fix is to replace \\ with \ in the regex.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253031: git jcheck complains about invalid tags in jdk repo after fix for JDK-8252844

Reviewers

• Erik Helin (@edvbld - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/131/head:pull/131
$ git checkout pull/131

[kevinrushforth]

/label build

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinrushforth
The build label was successfully added.

[openjdk]

@kevinrushforth To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request.

In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the /label add "label" command. The following labels are valid: 2d awt beans build compiler core-libs hotspot hotspot-compiler hotspot-gc hotspot-jfr hotspot-runtime i18n javadoc jdk jmx kulla net nio security serviceability shenandoah sound swing.

[mlbridge]

Webrevs

• 00: Full (81f7a3c)

[edvbld]

Looks good Kevin, thanks for fixing!

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253031: git jcheck complains about invalid tags in jdk repo after fix for JDK-8252844

Reviewed-by: ehelin, erikj

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch:

• 7f27d0b: 8236142: DocTrees should provide getCharacters(EntityTree)

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 7f27d0b0136f9acc9ff01e4b543edf31afc1cab3.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@edvbld, @erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[kevinrushforth]

/integrate

[openjdk]

@kevinrushforth
Your change (at version 81f7a3c) is now ready to be sponsored by a Committer.

[erikj79]

/integrate

[openjdk]

@erikj79 Only the author (@kevinrushforth) is allowed to issue the integrate command. As this PR is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

[erikj79]

/sponsor

[openjdk]

@erikj79 @kevinrushforth Since your change was applied there has been 1 commit pushed to the master branch:

• 7f27d0b: 8236142: DocTrees should provide getCharacters(EntityTree)

Your commit was automatically rebased without conflicts.

Pushed as commit 9525186.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.