Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8304539: Cleanup utilities/{count_leading_zeros,count_trailing_zeros,population_count}.hpp #13103

Closed
wants to merge 17 commits into from

Conversation

jcking
Copy link
Contributor

@jcking jcking commented Mar 20, 2023

As the title says, cleanup the mentioned headers. This is similar to byteswap.hpp and removes the extraneous #ifdef for XLC since it is really just Clang now.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8304539: Cleanup utilities/{count_leading_zeros,count_trailing_zeros,population_count}.hpp

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13103/head:pull/13103
$ git checkout pull/13103

Update a local copy of the PR:
$ git checkout pull/13103
$ git pull https://git.openjdk.org/jdk.git pull/13103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13103

View PR using the GUI difftool:
$ git pr show -t 13103

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13103.diff

Webrev

Link to Webrev Comment

Signed-off-by: Justin King <jcking@google.com>
Signed-off-by: Justin King <jcking@google.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2023

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 20, 2023
@openjdk
Copy link

openjdk bot commented Mar 20, 2023

@jcking The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Mar 20, 2023
@jcking
Copy link
Contributor Author

jcking commented Mar 20, 2023

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 20, 2023
@openjdk
Copy link

openjdk bot commented Mar 20, 2023

@jcking
The hotspot-runtime label was successfully added.

@jcking
Copy link
Contributor Author

jcking commented Mar 20, 2023

/reviewers 2

@openjdk
Copy link

openjdk bot commented Mar 20, 2023

@jcking
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@mlbridge
Copy link

mlbridge bot commented Mar 20, 2023

jcking added 10 commits March 20, 2023 11:12
Signed-off-by: Justin King <jcking@google.com>
Signed-off-by: Justin King <jcking@google.com>
Signed-off-by: Justin King <jcking@google.com>
Signed-off-by: Justin King <jcking@google.com>
Signed-off-by: Justin King <jcking@google.com>
Signed-off-by: Justin King <jcking@google.com>
Signed-off-by: Justin King <jcking@google.com>
Signed-off-by: Justin King <jcking@google.com>
Signed-off-by: Justin King <jcking@google.com>
@jcking jcking marked this pull request as draft March 24, 2023 18:09
@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 24, 2023
Signed-off-by: Justin King <jcking@google.com>
@jcking jcking marked this pull request as ready for review March 24, 2023 18:42
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 24, 2023
@jcking jcking marked this pull request as draft March 24, 2023 22:59
@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 24, 2023
Signed-off-by: Justin King <jcking@google.com>
@jcking jcking marked this pull request as ready for review March 24, 2023 23:03
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 24, 2023
Signed-off-by: Justin King <jcking@google.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2023

@jcking This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2023

@jcking This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant