8304420: Regression ~11% with Javac-Generates on all platforms in b14

[mcimadamore]

This patch fixes a performance regression introduced by JDK-8303820. The new code for dealing with type metadata makes excessive use of streams and optionals, leading to performance degradation. I've tweaked the code to use plain for loops, and also to use null instead of optionals. I've also added a new getMetadata method which accepts a map function (if metadata is found) as well as a default value (if metadata is not found) which makes usage from clients similar to just using optionals. This seems to revert performance numbers to what they were before the fix.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304420: Regression ~11% with Javac-Generates on all platforms in b14

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13104/head:pull/13104
$ git checkout pull/13104

Update a local copy of the PR:
$ git checkout pull/13104
$ git pull https://git.openjdk.org/jdk.git pull/13104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13104

View PR using the GUI difftool:
$ git pr show -t 13104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13104.diff

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcimadamore The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4081ae72)

[vicente-romero-oracle]

lgtm

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304420: Regression ~11% with Javac-Generates on all platforms in b14

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 622f239: 8304163: Move jdk.internal.module.ModuleInfoWriter to the test library
• 4c8c993: 8304364: [AIX] Build erroneously determines build disk is non-local when using GNU-utils df on AIX
• 4ed7350: 8304393: Provide method to iterate over regions of humongous object in G1
• eb73fa8: 8301715: CDS should be disabled in exploded JDK
• 80e9797: 8304433: cleanup sentence breaker code in DocTreeMaker
• c396f1e: 8304443: bootcycle builds fail after JDK-8015831
• ded6a81: 8303742: CompletableFuture.orTimeout leaks if the future completes exceptionally
• 652bda0: 8304411: Remove unused CardTable::clear

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mcimadamore]

/integrate

[openjdk]

Going to push as commit 42723dc.
Since your change was applied there have been 9 commits pushed to the master branch:

• 19f2edd: 8304541: Modules THROW_MSG_ should return nullptr instead of JNI_FALSE
• 622f239: 8304163: Move jdk.internal.module.ModuleInfoWriter to the test library
• 4c8c993: 8304364: [AIX] Build erroneously determines build disk is non-local when using GNU-utils df on AIX
• 4ed7350: 8304393: Provide method to iterate over regions of humongous object in G1
• eb73fa8: 8301715: CDS should be disabled in exploded JDK
• 80e9797: 8304433: cleanup sentence breaker code in DocTreeMaker
• c396f1e: 8304443: bootcycle builds fail after JDK-8015831
• ded6a81: 8303742: CompletableFuture.orTimeout leaks if the future completes exceptionally
• 652bda0: 8304411: Remove unused CardTable::clear

Your commit was automatically rebased without conflicts.

[openjdk]

@mcimadamore Pushed as commit 42723dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.