8303229: JFR: Preserve disk repository after exit

[egahlin]

Hi,

Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8303754 to be approved

Issues

• JDK-8303229: JFR: Preserve disk repository after exit
• JDK-8303754: JFR: Preserve disk repository after exit (CSR)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13111/head:pull/13111
$ git checkout pull/13111

Update a local copy of the PR:
$ git checkout pull/13111
$ git pull https://git.openjdk.org/jdk.git pull/13111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13111

View PR using the GUI difftool:
$ git pr show -t 13111

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13111.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following labels will be automatically applied to this pull request:

• build
• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 07: Full - Incremental (5a914ea7)
• 06: Full - Incremental (807d62b7)
• 05: Full - Incremental (c744b1c7)
• 04: Full - Incremental (2665c785)
• 03: Full - Incremental (6c860c1e)
• 02: Full - Incremental (0b500c8e)
• 01: Full - Incremental (9e8094d2)
• 00: Full (47d9b4d2)

[dholmes-ora]

@egahlin you to update this with latest master to get DCmd num_arguments changes that went in recently.

[dholmes-ora]

Also I would expect to see an update to the JFR manpage for this. Thanks.

[egahlin]

@egahlin you to update this with latest master to get DCmd num_arguments changes that went in recently.

Will fix.

[dholmes-ora]

Seems okay to me. Can't comment on the actual functionality.

Thanks.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303229: JFR: Preserve disk repository after exit

Reviewed-by: dholmes, mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 129 new commits pushed to the master branch:

• aa76210: 8304893: Link Time Optimization with gcc can be faster
• b8c748d: 8294266: Add a way to pre-touch java thread stacks
• 41a3db2: 8304815: Use NMT for more precise hs_err location printing
• 34e66ce: 8304295: harfbuzz build fails with GCC 7 after JDK-8301998
• a19b28a: 8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick
• 8eb4e7e: 8277501: Revisit PathFileObject.getCharContent and friends
• abfb900: 8304028: Port fdlibm IEEEremainder to Java
• a565be4: 8297605: improve DelayQueue removal method javadoc
• cccb019: 8304928: Optimize ClassDesc.resolveConstantDesc
• bdbf8fc: 8303930: Fix ConstantUtils.skipOverFieldSignature void case return value
• ... and 119 more: https://git.openjdk.org/jdk/compare/37774556da8a5aacf55884133ae936ed5a28eab2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mgronlun]

Looks good.

[egahlin]

/integrate

[openjdk]

Going to push as commit 336a23e.
Since your change was applied there have been 130 commits pushed to the master branch:

• ecec611: 8283404: [macos] a11y : Screen magnifier does not show JMenu name
• aa76210: 8304893: Link Time Optimization with gcc can be faster
• b8c748d: 8294266: Add a way to pre-touch java thread stacks
• 41a3db2: 8304815: Use NMT for more precise hs_err location printing
• 34e66ce: 8304295: harfbuzz build fails with GCC 7 after JDK-8301998
• a19b28a: 8297539: Use PrimitiveConversions::cast for local uses of the int<->float union conversion trick
• 8eb4e7e: 8277501: Revisit PathFileObject.getCharContent and friends
• abfb900: 8304028: Port fdlibm IEEEremainder to Java
• a565be4: 8297605: improve DelayQueue removal method javadoc
• cccb019: 8304928: Optimize ClassDesc.resolveConstantDesc
• ... and 120 more: https://git.openjdk.org/jdk/compare/37774556da8a5aacf55884133ae936ed5a28eab2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 336a23e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.