JDK-8303123: Add line break opportunity to single type parameters#13119
JDK-8303123: Add line break opportunity to single type parameters#13119hns wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into |
| code.add(typeParameters); | ||
| // Add explicit line break between method type parameters and | ||
| // return type in member summary table to avoid random wrapping. | ||
| if (typeParameters.charCount() > 10) { |
There was a problem hiding this comment.
Unrelated to this PR, I still dislike these unnamed numeric values.
jonathan-gibbons
left a comment
There was a problem hiding this comment.
Looks. good to me.
|
@hns This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 139 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 2e91585.
Your commit was automatically rebased without conflicts. |
Please review a simple change to add a
<wbr>(line break opportunity) tag before type parameters in some type links. This is only used in the first column of member summary tables as this is the only place where we have type names with full type parameters and no natural line break opportunities in a very limited horizontal space. Attached below is a screenshot of the method summary table ofjava.net.http.HttpResponse.BodySubscriberswith this fix applied (see JBS issue for a screenshot of the previous rendering).Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/13119/head:pull/13119$ git checkout pull/13119Update a local copy of the PR:
$ git checkout pull/13119$ git pull https://git.openjdk.org/jdk.git pull/13119/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13119View PR using the GUI difftool:
$ git pr show -t 13119Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/13119.diff